From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com, Eric Dumazet <edumazet@google.com>,
kernel@pengutronix.de, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <olteanv@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net v1 1/1] net: dsa: microchip: KSZ9893: do not write to not supported Output Clock Control Register
Date: Fri, 29 Jul 2022 08:41:49 -0700 [thread overview]
Message-ID: <20220729084149.5a061772@kernel.org> (raw)
In-Reply-To: <20220729094840.GB10850@pengutronix.de>
On Fri, 29 Jul 2022 11:48:40 +0200 Oleksij Rempel wrote:
> On Thu, Jul 28, 2022 at 10:23:16PM -0700, Jakub Kicinski wrote:
> > On Thu, 28 Jul 2022 15:18:52 +0200 Oleksij Rempel wrote:
> > > KSZ9893 compatible chips do not have "Output Clock Control Register 0x0103".
> > > So, avoid writing to it.
> >
> > Respin will be needed regardless of the answer to Andrew - patch does
> > not apply.
>
> Hm, this driver was hardly refactored in net-next. I'll better send it
> against net-next otherwise things will break.
Probably fine either way, with the net-next patch (i.e. this patch)
on the list we shouldn't have problems resolving the conflict correctly.
The real question is whether it's okay for 5.19 to not have this patch.
It'd be good to have the user-visible impact specified in the commit
message.
next prev parent reply other threads:[~2022-07-29 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 13:18 [PATCH net v1 1/1] net: dsa: microchip: KSZ9893: do not write to not supported Output Clock Control Register Oleksij Rempel
2022-07-28 13:34 ` Andrew Lunn
2022-07-29 5:23 ` Jakub Kicinski
2022-07-29 9:48 ` Oleksij Rempel
2022-07-29 15:41 ` Jakub Kicinski [this message]
2022-07-29 16:32 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729084149.5a061772@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).