From: Jakub Kicinski <kuba@kernel.org>
To: Subbaraya Sundeep <sbhatta@marvell.com>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
<sgoutham@marvell.com>, <netdev@vger.kernel.org>,
Suman Ghosh <sumang@marvell.com>
Subject: Re: [net v3 PATCH 3/5] octeontx2-af: Allow mkex profiles without dmac.
Date: Fri, 29 Jul 2022 21:20:04 -0700 [thread overview]
Message-ID: <20220729212004.7ca3f250@kernel.org> (raw)
In-Reply-To: <1659109430-31748-4-git-send-email-sbhatta@marvell.com>
On Fri, 29 Jul 2022 21:13:48 +0530 Subbaraya Sundeep wrote:
> It is possible to have custom mkex profiles which do not extract
> DMAC into the key to free up space in the key and use it for L3
> or L4 packet fields. Current code bails out if DMAC extraction is
> not present in the key. This patch fixes it by allowing profiles
> without DMAC and also supports installing rules based on L2MB bit
> set by hardware for multicast and broadcast packets.
>
> This patch also adds debugging prints needed to identify profiles
> with wrong configuration.
I had some questions about whether this is regression fix or new
feature and the size of this patch - which do not seem to have been
addressed.
next prev parent reply other threads:[~2022-07-30 4:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 15:43 [net v3 PATCH 0/5] Octeontx2 AF driver fixes for NPC Subbaraya Sundeep
2022-07-29 15:43 ` [net v3 PATCH 1/5] octeontx2-af: Apply tx nibble fixup always Subbaraya Sundeep
2022-07-29 15:43 ` [net v3 PATCH 2/5] octeontx2-af: suppress external profile loading warning Subbaraya Sundeep
2022-07-29 15:43 ` [net v3 PATCH 3/5] octeontx2-af: Allow mkex profiles without dmac Subbaraya Sundeep
2022-07-30 4:20 ` Jakub Kicinski [this message]
2022-07-30 7:24 ` Subbaraya Sundeep Bhatta
2022-07-29 15:43 ` [net v3 PATCH 4/5] octeontx2-af: Fix mcam entry resource leak Subbaraya Sundeep
2022-07-29 15:43 ` [net v3 PATCH 5/5] octeontx2-af: Fix key checking for source mac Subbaraya Sundeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729212004.7ca3f250@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).