* [PATCH -next] net: marvell: prestera: remove reduntant code
@ 2022-08-01 4:07 Sebin Sebastian
2022-08-02 3:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Sebin Sebastian @ 2022-08-01 4:07 UTC (permalink / raw)
Cc: mailmesebin00, Taras Chornyi, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, linux-kernel
Fixes the coverity warning 'EVALUATION_ORDER' violation. port is written
twice with the same value.
Fixes: Coverity CID 1519056 (Incorrect expression)
Signed-off-by: Sebin Sebastian <mailmesebin00@gmail.com>
---
drivers/net/ethernet/marvell/prestera/prestera_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index c267ca1ccdba..0df904455d76 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -290,7 +290,7 @@ static int prestera_pcs_config(struct phylink_pcs *pcs,
const unsigned long *advertising,
bool permit_pause_to_mac)
{
- struct prestera_port *port = port = prestera_pcs_to_port(pcs);
+ struct prestera_port *port = prestera_pcs_to_port(pcs);
struct prestera_port_mac_config cfg_mac;
int err;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: marvell: prestera: remove reduntant code
2022-08-01 4:07 [PATCH -next] net: marvell: prestera: remove reduntant code Sebin Sebastian
@ 2022-08-02 3:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-08-02 3:40 UTC (permalink / raw)
To: Sebin Sebastian
Cc: tchornyi, davem, edumazet, kuba, pabeni, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 1 Aug 2022 09:37:31 +0530 you wrote:
> Fixes the coverity warning 'EVALUATION_ORDER' violation. port is written
> twice with the same value.
>
> Fixes: Coverity CID 1519056 (Incorrect expression)
> Signed-off-by: Sebin Sebastian <mailmesebin00@gmail.com>
> ---
> drivers/net/ethernet/marvell/prestera/prestera_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [-next] net: marvell: prestera: remove reduntant code
https://git.kernel.org/netdev/net-next/c/969e26c63d30
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-02 3:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-01 4:07 [PATCH -next] net: marvell: prestera: remove reduntant code Sebin Sebastian
2022-08-02 3:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).