* [PATCH linux-next] iavf: Remove the unused conditional statements
@ 2022-08-01 2:27 cgel.zte
2022-08-01 16:13 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-08-01 2:27 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, ye xingchen, Zeal Robot
From: ye xingchen <ye.xingchen@zte.com.cn>
Conditional statements have no effect to next process.So remove it.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index e78c38d02432..b75e3e1119bd 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -2131,8 +2131,6 @@ iavf_set_vlan_offload_features(struct iavf_adapter *adapter,
vlan_ethertype = ETH_P_8021Q;
else if (prev_features & (NETIF_F_HW_VLAN_STAG_RX | NETIF_F_HW_VLAN_STAG_TX))
vlan_ethertype = ETH_P_8021AD;
- else if (prev_features & (NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_CTAG_TX))
- vlan_ethertype = ETH_P_8021Q;
else
vlan_ethertype = ETH_P_8021Q;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] iavf: Remove the unused conditional statements
2022-08-01 2:27 [PATCH linux-next] iavf: Remove the unused conditional statements cgel.zte
@ 2022-08-01 16:13 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-08-01 16:13 UTC (permalink / raw)
To: cgel.zte; +Cc: linux-kernel, netdev, ye xingchen, Zeal Robot
On Mon, 1 Aug 2022 02:27:54 +0000 cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Conditional statements have no effect to next process.So remove it.
Nack, it's the default statement. Please fix the tool which makes you
send these patches.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-01 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-01 2:27 [PATCH linux-next] iavf: Remove the unused conditional statements cgel.zte
2022-08-01 16:13 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).