From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2447C19F2C for ; Mon, 1 Aug 2022 19:25:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233882AbiHATZG (ORCPT ); Mon, 1 Aug 2022 15:25:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229966AbiHATZE (ORCPT ); Mon, 1 Aug 2022 15:25:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E27A2B260; Mon, 1 Aug 2022 12:25:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3D257B8165B; Mon, 1 Aug 2022 19:25:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D33BC433C1; Mon, 1 Aug 2022 19:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659381900; bh=EkphSiEPzZcfk1if8b0j8p5iyfVhuflocYAWfz/z4jI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oLk/fb5Z4LqluhUn1lzqmrUPZhINv+0erHHu2lr2aBqjlzCs8KYabeefJUDajb9ot 2GsUuYcob+13QutflZnujP5bAxLMOzdAJN4egobeOkRNJrle6al3NKc4WaVcS6ECdC sc+GipKrf4QP+tAFSENHJuCyhzRHB2injSWWm3B4PLkvsQ/T3hd44gLoKd/bKO9vez PcNcTvtQZIFjh5OBogxYMKxjqmtwAye81cipadY4M7nDUfvZfWl6HMxPyF/+P1I2Oi vnJ+g4H4+TLiphqQvyxwm4BJ+zm+AhsRyxfyK5COHptwWSSH7547i1oo/Zx9Y/zTvH +qwYyPjnsRlHQ== Date: Mon, 1 Aug 2022 12:24:59 -0700 From: Jakub Kicinski To: Colin Ian King Cc: Boris Pismenny , John Fastabend , "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] tls: rx: Fix less than zero check on unsigned variable sz Message-ID: <20220801122459.57b7df02@kernel.org> In-Reply-To: <20220730114027.142376-1-colin.i.king@gmail.com> References: <20220730114027.142376-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 30 Jul 2022 12:40:27 +0100 Colin Ian King wrote: > Variable sz is declared as an unsigned size_t and is being checked > for an less than zero error return on a call to tls_rx_msg_size. > Fix this by making sz an int. > > Fixes: 84c61fe1a75b ("tls: rx: do not use the standard strparser") > Signed-off-by: Colin Ian King > --- > net/tls/tls_strp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Already fixed 2 days before you posted, I guess linux-next lagged. commit 8fd1e151779285b211e7184e9237bba69bd74386 Author: Yang Li AuthorDate: Wed Jul 27 20:10:19 2022 Commit: Jakub Kicinski CommitDate: Thu Jul 28 21:50:39 2022 tls: rx: Fix unsigned comparison with less than zero