From: Jakub Kicinski <kuba@kernel.org>
To: "Jiawen Wu" <jiawenwu@trustnetic.com>
Cc: "'Christophe JAILLET'" <christophe.jaillet@wanadoo.fr>,
"'David S. Miller'" <davem@davemloft.net>,
"'Eric Dumazet'" <edumazet@google.com>,
"'Paolo Abeni'" <pabeni@redhat.com>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH] net: txgbe: Fix an error handling path in txgbe_probe()
Date: Mon, 1 Aug 2022 12:31:42 -0700 [thread overview]
Message-ID: <20220801123142.559ca297@kernel.org> (raw)
In-Reply-To: <02a101d8a552$0e704650$2b50d2f0$@trustnetic.com>
On Mon, 1 Aug 2022 10:54:44 +0800 Jiawen Wu wrote:
> On Monday, August 1, 2022 12:34 AM, Christophe wrote:
> > A pci_enable_pcie_error_reporting() should be balanced by a corresponding
> > pci_disable_pcie_error_reporting() call in the error handling path, as already
> > done in the remove function.
>
> Thanks Christophe, it's right.
> Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>
Your reply did not make it to the list:
https://lore.kernel.org/r/02a101d8a552$0e704650$2b50d2f0$@trustnetic.com+898582B7F010EAA4/
not sure why but I wanted to let you know.
Thanks for reviewing the fix promptly!
prev parent reply other threads:[~2022-08-01 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-31 16:34 [PATCH] net: txgbe: Fix an error handling path in txgbe_probe() Christophe JAILLET
2022-08-01 19:30 ` patchwork-bot+netdevbpf
[not found] ` <02a101d8a552$0e704650$2b50d2f0$@trustnetic.com>
2022-08-01 19:31 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801123142.559ca297@kernel.org \
--to=kuba@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).