From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A266FC00140 for ; Tue, 2 Aug 2022 15:38:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230073AbiHBPib (ORCPT ); Tue, 2 Aug 2022 11:38:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229645AbiHBPib (ORCPT ); Tue, 2 Aug 2022 11:38:31 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A58F1276F for ; Tue, 2 Aug 2022 08:38:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EFB56B819F1 for ; Tue, 2 Aug 2022 15:38:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C624C43470; Tue, 2 Aug 2022 15:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659454707; bh=fIzCJ/A8a6vH6/x7cNhJl398mBXjZu6wrbWG9gXcteI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dCL8WEVJftCZFzvalMiYtPY/3iawj0EAS5cGjCpsgqCr0m0MhT2QWTSijn3DlQqAD ZwyLo+7ZeSzBrH1u+E260VGDQA/dd/tUpRDC5dPV2ds8D1e3arbnO2o9GNAMpH2G21 on6zDgdbSSwH8iGrOmhlr4xx4cCv8EWfngOGQDdnbCIBZCvajI/qfl1KCHvsyhQY6/ osYVe0k0GFga1zgtN46O9SWu2kzRbKMi/BUNvbv6VqWXsfnPqcre/UwIeB09EE7OKf UmK7J45GdcS+a78WSu3AkT96zLpKNAZRDamqlCXTcWz8o2EMiVEvdNtRkYxTqpF84W AoT1KrEX1CgAQ== Date: Tue, 2 Aug 2022 08:38:26 -0700 From: Jakub Kicinski To: Maxim Mikityanskiy Cc: "davem@davemloft.net" , Tariq Toukan , Gal Pressman , "john.fastabend@gmail.com" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "edumazet@google.com" , Saeed Mahameed , Boris Pismenny Subject: Re: [PATCH net-next] net/tls: Use RCU API to access tls_ctx->netdev Message-ID: <20220802083826.162077f2@kernel.org> In-Reply-To: <4a49be4bb85f99de60cfec4c57bce5f1a356416f.camel@nvidia.com> References: <20220801080053.21849-1-maximmi@nvidia.com> <20220801124419.4aaffcac@kernel.org> <4a49be4bb85f99de60cfec4c57bce5f1a356416f.camel@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2 Aug 2022 12:07:18 +0000 Maxim Mikityanskiy wrote: > > Oops, looks like we also got some new sparse warnings from this: > > > > 2 new warnings in drivers/net/bonding/bond_main.c > > 1 new warning in drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c > > Looks like neither me, nor our internal CI built these files - sorry! > I'll fix these and look for the usages more carefully. > > BTW, the bonding case misses even the READ_ONCE, so it's an existing > bug, exposed by the transition to the proper RCU API in my patch. Nice! You can slap a fixes tag on it, for accounting purposes, and stick to net-next in the subject, tree doesn't matter right now.