From: Jakub Kicinski <kuba@kernel.org>
To: Richard Gobert <richardbgobert@gmail.com>
Cc: davem@davemloft.net, pabeni@redhat.com, yoshfuji@linux-ipv6.org,
dsahern@kernel.org, xeb@mail.ru, edumazet@google.com,
roopa@nvidia.com, bigeasy@linutronix.de, iwienand@redhat.com,
heikki.krogerus@linux.intel.com, arnd@arndb.de,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: gro: skb_gro_header helper function
Date: Tue, 2 Aug 2022 12:28:44 -0700 [thread overview]
Message-ID: <20220802122844.56ddafd8@kernel.org> (raw)
In-Reply-To: <20220802142842.GA2524@debian>
On Tue, 2 Aug 2022 16:38:02 +0200 Richard Gobert wrote:
> Introduce a simple helper function to replace a common pattern.
> When accessing the GRO header, we fetch the pointer from frag0,
> then test its validity and fetch it from the skb when necessary.
>
> This leads to the pattern
> skb_gro_header_fast -> skb_gro_header_hard -> skb_gro_header_slow
> recurring many times throughout GRO code.
>
> This patch replaces these patterns with a single inlined function
> call, improving code readability.
>
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
# Form letter - net-next is closed
The merge window for Linux 6.0 has started and therefore
net-next is closed for new drivers, features, code refactoring
and optimizations. We are currently accepting bug fixes only.
Please repost when net-next reopens after 6.0-rc1 is cut.
RFC patches sent for review only are obviously welcome at any time.
next prev parent reply other threads:[~2022-08-02 19:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 14:38 [PATCH v2] net: gro: skb_gro_header helper function Richard Gobert
2022-08-02 19:28 ` Jakub Kicinski [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-23 7:10 [PATCH V2] " Richard Gobert
2022-08-23 16:36 ` Eric Dumazet
2022-08-25 8:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220802122844.56ddafd8@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=iwienand@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardbgobert@gmail.com \
--cc=roopa@nvidia.com \
--cc=xeb@mail.ru \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).