From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 433D4C19F28 for ; Wed, 3 Aug 2022 04:43:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232116AbiHCEnE (ORCPT ); Wed, 3 Aug 2022 00:43:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiHCEnD (ORCPT ); Wed, 3 Aug 2022 00:43:03 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D44322521 for ; Tue, 2 Aug 2022 21:43:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5683FB82121 for ; Wed, 3 Aug 2022 04:43:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92DA0C433D6; Wed, 3 Aug 2022 04:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659501779; bh=todqXPywndklh/57Gl2ztYsJ/gTQb5fJPANd69bmzRY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M2IV+QxJcPieE9PseZHJsomroaqCVLJ34LDsdKrEnwq2qUVfbZDLP5Bv6x+Xwidyh DkMwFzwx4h9KfvLl4dT4HtumkjRJRj2dm3ElKkP2k+D6l6MHNd2kKHanghSXgPAIoT CHBR6TEqNvfVc1wxJUX9RlyzdJYBowTDPqMgmW0HvwNXPdMYM+t205U90AosWZBJZ5 7GaKSPXyfyoghe33dUYgTt7FPrO4o1vxei2GLo3uvm7GcTj/prd2/lYY9KMjc4YCwG nXZtiU2RCu/dVLf8ZmlGCvRQW4DDBtFGyqHDu+mT+s6EJ3jtFnYlhGzxRJWvZ2MQRP NnZNBkIiHpMEw== Date: Tue, 2 Aug 2022 21:42:58 -0700 From: Jakub Kicinski To: Cezar Bulinaru Cc: davem@davemloft.net, willemb@google.com, netdev@vger.kernel.org Subject: Re: [PATCH v4 1/2] net: tap: NULL pointer derefence in dev_parse_header_protocol when skb->dev is null Message-ID: <20220802214258.23d1d788@kernel.org> In-Reply-To: <20220803042845.5754-1-cbulinaru@gmail.com> References: <20220803042845.5754-1-cbulinaru@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 3 Aug 2022 00:28:45 -0400 Cezar Bulinaru wrote: > Fixes a NULL pointer derefence bug triggered from tap driver. > When tap_get_user calls virtio_net_hdr_to_skb the skb->dev is null > (in tap.c skb->dev is set after the call to virtio_net_hdr_to_skb) > virtio_net_hdr_to_skb calls dev_parse_header_protocol which > needs skb->dev field to be valid. Could you repost these patches as a normal, standalone series, with no fancy in-reply-to? Put [PATCH net v5] as the subject prefix. Patchwork bot is unable to follow your creativity it seems.