From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C83CEC19F2D for ; Wed, 3 Aug 2022 11:30:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233073AbiHCLa4 (ORCPT ); Wed, 3 Aug 2022 07:30:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236312AbiHCLau (ORCPT ); Wed, 3 Aug 2022 07:30:50 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 011F22A43C for ; Wed, 3 Aug 2022 04:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659526249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ACliQ9oJqgCoHX8Ef7C87bGSwzNCX201dby99j7oUC8=; b=P1pXfb0p8rGSq/Zm/1FllzqVcQkOMkXuv/JBIxh4577DovpaC80Dw3FKLrAEsnI+B3SBPt GJd3AeYQo5n++gZwiRiXRGNmYR1Pk0hqjwR85HnPQA8BDUp/ABH6ZMEp1v90N9KMOlp1yx Wqy2Qb19xlwuAoS8Azm3sFurQ4gMMFk= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-396-LMs73NxkP7yPs6mpgNUMjw-1; Wed, 03 Aug 2022 07:30:48 -0400 X-MC-Unique: LMs73NxkP7yPs6mpgNUMjw-1 Received: by mail-qv1-f69.google.com with SMTP id o9-20020a0cecc9000000b0047491274bb1so7664136qvq.19 for ; Wed, 03 Aug 2022 04:30:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ACliQ9oJqgCoHX8Ef7C87bGSwzNCX201dby99j7oUC8=; b=rZH+xbH3c0k2KaS/yGcJqKF9AYJCNHEpBiqHOpyf2cQ6IYeT7m63u9CZKub40aRMbd n3gzs/53DynvwtFhO7XY0g7wbtYjQG9GmEExWPzobTFPCoGn+uklicNqtInf2K+RcT2a nwvOOzuLpU2GqD8LAo19miQup5zjbG1gCFtUa1dvb+tZGtnLn/oV0kLkDaU5ijDGN44N 5bhzq/Eyo9+YdyC/SbvrV3w9hnScJRsbUi7/xCgh++Mj2hngfdYlAVaqHRaGM741k33x QQPQ5rlmOxRBM0/gG45awUa6EAZqRKQDv6omK9u0UAn+Z61pWPSDerwWPO6q1VXcCQKP J92A== X-Gm-Message-State: AJIora+HErV1Sg/oGH/VFRPDmwIct6WfXFoRsbM5cARKTzObCcYQPD4w LYHJJSeNTBf1aP71A4yNlBHPKFj7MtaFVcOviyoqMJAgBozuh/dLYaC6wgHvggU0PRGsZQT1Bkk HyhSqKjsvtAjDdhYS X-Received: by 2002:ac8:59d5:0:b0:31f:dde:fca8 with SMTP id f21-20020ac859d5000000b0031f0ddefca8mr22345815qtf.86.1659526247476; Wed, 03 Aug 2022 04:30:47 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sN0PZbJQ7Njk6l2cfsYiD8YZMh9JnksyXTAlgE0zWDCVaHwC+6GHlYXN2nC/9NqFsBWxtlVQ== X-Received: by 2002:ac8:59d5:0:b0:31f:dde:fca8 with SMTP id f21-20020ac859d5000000b0031f0ddefca8mr22345807qtf.86.1659526247297; Wed, 03 Aug 2022 04:30:47 -0700 (PDT) Received: from pc-4.home (2a01cb058918ce00dd1a5a4f9908f2d5.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:dd1a:5a4f:9908:f2d5]) by smtp.gmail.com with ESMTPSA id n15-20020a05620a294f00b006b5cc25535fsm12275757qkp.99.2022.08.03.04.30.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Aug 2022 04:30:46 -0700 (PDT) Date: Wed, 3 Aug 2022 13:30:41 +0200 From: Guillaume Nault To: Matthias May Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, roopa@nvidia.com, eng.alaamohamedsoliman.am@gmail.com, bigeasy@linutronix.de, saeedm@nvidia.com, leon@kernel.org, roid@nvidia.com, maord@nvidia.com, lariel@nvidia.com, vladbu@nvidia.com, cmi@nvidia.com, yoshfuji@linux-ipv6.org, dsahern@kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, nicolas.dichtel@6wind.com, eyal.birger@gmail.com, jesse@nicira.com, linville@tuxdriver.com, daniel@iogearbox.net, hadarh@mellanox.com, ogerlitz@mellanox.com, willemb@google.com, martin.varghese@nokia.com Subject: Re: [PATCH v2 net 1/4] geneve: do not use RT_TOS for IPv6 flowlabel Message-ID: <20220803113041.GC29408@pc-4.home> References: <20220802120935.1363001-1-matthias.may@westermo.com> <20220802120935.1363001-2-matthias.may@westermo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220802120935.1363001-2-matthias.may@westermo.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 02, 2022 at 02:09:32PM +0200, Matthias May wrote: > According to Guillaume Nault RT_TOS should never be used for IPv6. > > Fixes: 3a56f86f1be6a ("geneve: handle ipv6 priority like ipv4 tos") While I'm at it, the SHA1 is normally truncated to 12 charaters, not 13. > Signed-off-by: Matthias May > --- > v1 -> v2: > - Fix spacing of "Fixes" tag. > - Add missing CCs > --- > drivers/net/geneve.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 4c380c06f178..e1a4480e6f17 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > @@ -877,8 +877,7 @@ static struct dst_entry *geneve_get_v6_dst(struct sk_buff *skb, > use_cache = false; > } > > - fl6->flowlabel = ip6_make_flowinfo(RT_TOS(prio), > - info->key.label); > + fl6->flowlabel = ip6_make_flowinfo(prio, info->key.label); > dst_cache = (struct dst_cache *)&info->dst_cache; > if (use_cache) { > dst = dst_cache_get_ip6(dst_cache, &fl6->saddr); > -- > 2.35.1 >