* [PATCH v2 net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
@ 2022-08-05 20:27 Jose Alonso
2022-08-06 0:51 ` Jakub Kicinski
2022-08-06 15:23 ` Andrew Lunn
0 siblings, 2 replies; 4+ messages in thread
From: Jose Alonso @ 2022-08-05 20:27 UTC (permalink / raw)
To: David S. Miller, Greg Kroah-Hartman; +Cc: netdev, stable, Ronald Wahl
To: David S. Miller <davem@davemloft.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: netdev <netdev@vger.kernel.org>, stable <stable@vger.kernel.org>, Ronald Wahl <ronald.wahl@raritan.com>
[PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware
versions that have no issues.
The FLAG_SEND_ZLP is not safe to use in this context.
See:
https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378
Reported-by: Ronald Wahl <ronald.wahl@raritan.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216327
Link: https://bugs.archlinux.org/task/75491
Fixes: 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")
Signed-off-by: Jose Alonso <joalonsof@gmail.com>
--
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index 0ad468a00064..aff39bf3161d 100644
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -1680,7 +1680,7 @@ static const struct driver_info ax88179_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
@@ -1693,7 +1693,7 @@ static const struct driver_info ax88178a_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
@@ -1706,7 +1706,7 @@ static const struct driver_info cypress_GX3_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
@@ -1719,7 +1719,7 @@ static const struct driver_info dlink_dub1312_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
@@ -1732,7 +1732,7 @@ static const struct driver_info sitecom_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
@@ -1745,7 +1745,7 @@ static const struct driver_info samsung_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
@@ -1758,7 +1758,7 @@ static const struct driver_info lenovo_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
@@ -1771,7 +1771,7 @@ static const struct driver_info belkin_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
@@ -1784,7 +1784,7 @@ static const struct driver_info toshiba_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
@@ -1797,7 +1797,7 @@ static const struct driver_info mct_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
@@ -1810,7 +1810,7 @@ static const struct driver_info at_umc2000_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
@@ -1823,7 +1823,7 @@ static const struct driver_info at_umc200_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
@@ -1836,7 +1836,7 @@ static const struct driver_info at_umc2000sp_info = {
.link_reset = ax88179_link_reset,
.reset = ax88179_reset,
.stop = ax88179_stop,
- .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX,
.rx_fixup = ax88179_rx_fixup,
.tx_fixup = ax88179_tx_fixup,
};
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
2022-08-05 20:27 [PATCH v2 net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP Jose Alonso
@ 2022-08-06 0:51 ` Jakub Kicinski
2022-08-08 11:27 ` Jose Alonso
2022-08-06 15:23 ` Andrew Lunn
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2022-08-06 0:51 UTC (permalink / raw)
To: Jose Alonso
Cc: David S. Miller, Greg Kroah-Hartman, netdev, stable, Ronald Wahl
On Fri, 05 Aug 2022 17:27:33 -0300 Jose Alonso wrote:
> To: David S. Miller <davem@davemloft.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: netdev <netdev@vger.kernel.org>, stable <stable@vger.kernel.org>, Ronald Wahl <ronald.wahl@raritan.com>
>
> [PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
> The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware
> versions that have no issues.
But you tested with 1790 previously so isn't the misbehaviour on that
device going to come back if we remove the flag again?
> The FLAG_SEND_ZLP is not safe to use in this context.
> See:
> https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378
>
> Reported-by: Ronald Wahl <ronald.wahl@raritan.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216327
> Link: https://bugs.archlinux.org/task/75491
>
> Fixes: 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")
> Signed-off-by: Jose Alonso <joalonsof@gmail.com>
The commit message looks unnecessarily indented, could you try with git
format-patch / git send-email?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
2022-08-05 20:27 [PATCH v2 net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP Jose Alonso
2022-08-06 0:51 ` Jakub Kicinski
@ 2022-08-06 15:23 ` Andrew Lunn
1 sibling, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2022-08-06 15:23 UTC (permalink / raw)
To: Jose Alonso
Cc: David S. Miller, Greg Kroah-Hartman, netdev, stable, Ronald Wahl
On Fri, Aug 05, 2022 at 05:27:33PM -0300, Jose Alonso wrote:
> To: David S. Miller <davem@davemloft.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: netdev <netdev@vger.kernel.org>, stable <stable@vger.kernel.org>, Ronald Wahl <ronald.wahl@raritan.com>
>
> [PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
> The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware
> versions that have no issues.
>
> The FLAG_SEND_ZLP is not safe to use in this context.
> See:
> https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378
>
> Reported-by: Ronald Wahl <ronald.wahl@raritan.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216327
> Link: https://bugs.archlinux.org/task/75491
>
> Fixes: 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP")
> Signed-off-by: Jose Alonso <joalonsof@gmail.com>
>
> --
Please take a read of:
https://kernel.org/doc/html/latest/process/submitting-patches.html
It should explain all the things you are getting wrong.
It is also worth looking at a few patches on the mailing list which do
get accepted. Look at there format and copy them.
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
2022-08-06 0:51 ` Jakub Kicinski
@ 2022-08-08 11:27 ` Jose Alonso
0 siblings, 0 replies; 4+ messages in thread
From: Jose Alonso @ 2022-08-08 11:27 UTC (permalink / raw)
To: Jakub Kicinski
Cc: David S. Miller, Greg Kroah-Hartman, netdev, stable, Ronald Wahl
On Fri, 2022-08-05 at 17:51 -0700, Jakub Kicinski wrote:
> On Fri, 05 Aug 2022 17:27:33 -0300 Jose Alonso wrote:
> > To: David S. Miller <davem@davemloft.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: netdev <netdev@vger.kernel.org>, stable <stable@vger.kernel.org>, Ronald Wahl <ronald.wahl@raritan.com>
> >
> > [PATCH net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP
> > The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware
> > versions that have no issues.
>
> But you tested with 1790 previously so isn't the misbehaviour on that
> device going to come back if we remove the flag again?
>
>
There are also 0b95:1790 devices with probably different firmware/hardware
version that have issues with the patch.
The original problem needs another way to solve.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-08 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-05 20:27 [PATCH v2 net] net: usb: ax88179_178a have issues with FLAG_SEND_ZLP Jose Alonso
2022-08-06 0:51 ` Jakub Kicinski
2022-08-08 11:27 ` Jose Alonso
2022-08-06 15:23 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).