From: Guillaume Nault <gnault@redhat.com>
To: Matthias May <matthias.may@westermo.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, nicolas.dichtel@6wind.com,
eyal.birger@gmail.com, linux-kernel@vger.kernel.org,
jesse@nicira.com, pshelar@nicira.com, tgraf@suug.ch
Subject: Re: [PATCH v4 net] geneve: fix TOS inheriting for ipv4
Date: Mon, 8 Aug 2022 14:27:51 +0200 [thread overview]
Message-ID: <20220808122751.GB9123@pc-4.home> (raw)
In-Reply-To: <20220805190006.8078-1-matthias.may@westermo.com>
On Fri, Aug 05, 2022 at 09:00:06PM +0200, Matthias May wrote:
> The current code retrieves the TOS field after the lookup
> on the ipv4 routing table. The routing process currently
> only allows routing based on the original 3 TOS bits, and
> not on the full 6 DSCP bits.
> As a result the retrieved TOS is cut to the 3 bits.
> However for inheriting purposes the full 6 bits should be used.
>
> Extract the full 6 bits before the route lookup and use
> that instead of the cut off 3 TOS bits.
Acked-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2022-08-08 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 19:00 [PATCH v4 net] geneve: fix TOS inheriting for ipv4 Matthias May
2022-08-08 12:27 ` Guillaume Nault [this message]
2022-08-10 5:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808122751.GB9123@pc-4.home \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eyal.birger@gmail.com \
--cc=jesse@nicira.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.may@westermo.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=pshelar@nicira.com \
--cc=tgraf@suug.ch \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox