From: Jakub Kicinski <kuba@kernel.org>
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] tsnep: Fix tsnep_tx_unmap() error path usage
Date: Mon, 8 Aug 2022 14:30:36 -0700 [thread overview]
Message-ID: <20220808143036.2f22e809@kernel.org> (raw)
In-Reply-To: <44114097-15bc-77ff-51f5-bfc0b5e02b70@engleder-embedded.com>
On Mon, 8 Aug 2022 21:30:02 +0200 Gerhard Engleder wrote:
> On 08.08.22 21:23, Jakub Kicinski wrote:
> > On Thu, 4 Aug 2022 20:39:35 +0200 Gerhard Engleder wrote:
> >> If tsnep_tx_map() fails, then tsnep_tx_unmap() shall start at the write
> >> index like tsnep_tx_map(). This is different to the normal operation.
> >> Thus, add an additional parameter to tsnep_tx_unmap() to enable start at
> >> different positions for successful TX and failed TX.
> >>
> >> Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com>
> > Is this correct:
> >
> > Fixes: 403f69bbdbad ("tsnep: Add TSN endpoint Ethernet MAC driver")
> >
> > ?
> Yes, that's correct. Sorry I forget to add it. Shall I add it and resend?
It's okay, I'll add it.
next prev parent reply other threads:[~2022-08-08 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 18:39 [PATCH net-next 0/2] tsnep: Two fixes for the driver Gerhard Engleder
2022-08-04 18:39 ` [PATCH net-next 1/2] tsnep: Fix unused warning for 'tsnep_of_match' Gerhard Engleder
2022-08-04 18:39 ` [PATCH net-next 2/2] tsnep: Fix tsnep_tx_unmap() error path usage Gerhard Engleder
2022-08-08 19:23 ` Jakub Kicinski
2022-08-08 19:29 ` Gerhard Engleder
2022-08-08 19:30 ` Gerhard Engleder
2022-08-08 21:30 ` Jakub Kicinski [this message]
2022-08-09 3:50 ` [PATCH net-next 0/2] tsnep: Two fixes for the driver patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808143036.2f22e809@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=gerhard@engleder-embedded.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).