From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF397C00140 for ; Wed, 10 Aug 2022 17:15:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233385AbiHJRP0 (ORCPT ); Wed, 10 Aug 2022 13:15:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233155AbiHJRPY (ORCPT ); Wed, 10 Aug 2022 13:15:24 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7441C4F1AC for ; Wed, 10 Aug 2022 10:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660151722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pJn/IZwwCUJaRkHAplLUe6h5lh+4WbyzcUt1/ayUEH8=; b=P2R89P0sI0U+qV5VhetNO2uQ7dhhiYn926PefKFPrtJhFSqK4vcnMjYUA20rVh4rCAuYEy tOiVcUg21/Tfqok83ZKr6Bv8vGZKMFe1XBl3g3g3ANEuUsraVbSv2b2C23eL91L6UhtTu5 AFgoeR8OzIUSrn4fSQFW7tAr6q+2TtY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-509-8vtarA0BMqWU1cnKiPawGg-1; Wed, 10 Aug 2022 13:15:20 -0400 X-MC-Unique: 8vtarA0BMqWU1cnKiPawGg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 83E5F1C006C3; Wed, 10 Aug 2022 17:15:19 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.193.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id 344011410DDA; Wed, 10 Aug 2022 17:15:14 +0000 (UTC) From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: kvm@vger.kernel.org, "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, Jason Wang , virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Cc: dinang@xilinx.com, martinpo@xilinx.com, Wu Zongyong , Piotr.Uminski@intel.com, gautam.dawar@amd.com, ecree.xilinx@gmail.com, martinh@xilinx.com, Stefano Garzarella , pabloc@xilinx.com, habetsm.xilinx@gmail.com, lvivier@redhat.com, Zhu Lingshan , tanuj.kamde@amd.com, Longpeng , lulu@redhat.com, hanand@xilinx.com, Parav Pandit , Si-Wei Liu , Eli Cohen , Xie Yongji , Zhang Min , Dan Carpenter , Christophe JAILLET Subject: [PATCH v7 0/4] Implement vdpasim suspend operation Date: Wed, 10 Aug 2022 19:15:08 +0200 Message-Id: <20220810171512.2343333-1-eperezma@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Implement suspend operation for vdpa_sim devices, so vhost-vdpa will offer= =0D that backend feature and userspace can effectively suspend the device.=0D =0D This is a must before getting virtqueue indexes (base) for live migration,= =0D since the device could modify them after userland gets them. There are=0D individual ways to perform that action for some devices=0D (VHOST_NET_SET_BACKEND, VHOST_VSOCK_SET_RUNNING, ...) but there was no=0D way to perform it for any vhost device (and, in particular, vhost-vdpa).=0D =0D After a successful return of ioctl the device must not process more virtque= ue=0D descriptors. The device can answer to read or writes of config fields as if= it=0D were not suspended. In particular, writing to "queue_enable" with a value o= f 1=0D will not make the device start processing virtqueue buffers.=0D =0D In the future, we will provide features similar to=0D VHOST_USER_GET_INFLIGHT_FD so the device can save pending operations.=0D =0D Applied on top of [1] branch after removing the old commits.=0D =0D Comments are welcome.=0D =0D v7:=0D * Remove ioctl leftover argument and update doc accordingly.=0D =0D v6:=0D * Remove the resume operation, making the ioctl simpler. We can always add= =0D another ioctl for VM_STOP/VM_RESUME operation later.=0D * s/stop/suspend/ to differentiate more from reset.=0D * Clarify scope of the suspend operation.=0D =0D v5:=0D * s/not stop/resume/ in doc.=0D =0D v4:=0D * Replace VHOST_STOP to VHOST_VDPA_STOP in vhost ioctl switch case too.=0D =0D v3:=0D * s/VHOST_STOP/VHOST_VDPA_STOP/=0D * Add documentation and requirements of the ioctl above its definition.=0D =0D v2:=0D * Replace raw _F_STOP with BIT_ULL(_F_STOP).=0D * Fix obtaining of stop ioctl arg (it was not obtained but written).=0D * Add stop to vdpa_sim_blk.=0D =0D [1] git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git=0D =0D Eugenio P=C3=A9rez (4):=0D vdpa: Add suspend operation=0D vhost-vdpa: introduce SUSPEND backend feature bit=0D vhost-vdpa: uAPI to suspend the device=0D vdpa_sim: Implement suspend vdpa op=0D =0D drivers/vdpa/vdpa_sim/vdpa_sim.c | 14 +++++++++++=0D drivers/vdpa/vdpa_sim/vdpa_sim.h | 1 +=0D drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 3 +++=0D drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 3 +++=0D drivers/vhost/vdpa.c | 35 +++++++++++++++++++++++++++-=0D include/linux/vdpa.h | 4 ++++=0D include/uapi/linux/vhost.h | 9 +++++++=0D include/uapi/linux/vhost_types.h | 2 ++=0D 8 files changed, 70 insertions(+), 1 deletion(-)=0D =0D -- =0D 2.31.1=0D =0D