From: Benedict Wong <benedictwong@google.com>
To: steffen.klassert@secunet.com, netdev@vger.kernel.org
Cc: nharold@google.com, benedictwong@google.com, lorenzo@google.com
Subject: [PATCH ipsec 0/2] xfrm: Fix bugs in stacked XFRM-I tunnels
Date: Wed, 10 Aug 2022 18:22:08 +0000 [thread overview]
Message-ID: <20220810182210.721493-1-benedictwong@google.com> (raw)
This patch set fixes bugs that prevent stacked IPsec tunnels (via XFRM
interfaces) from receiving packets properly. The apparent cause of the
issues is that the inner tunnel’s policy checks fail to validate the
outer tunnel’s secpath entries (since it no longer has a reference to
the outer tunnel policies, and each call validates ALL secpath entries)
prior to verifying the inner tunnel’s. This patch set fixes this by
caching the list of verified secpath entries, and skipping them upon
future validation runs.
PATCH 1/2 Ensures that policies for nested tunnel mode transforms are
checked before additional decapsulation. This ensures that entries in
the secpath are verified while the context (intermediate IP addresses,
marks, etc) can be appropriately matched.
PATCH 2/2 Skips template matching for previously verified entries in
the secpath. This ensures that each tunnel is responsible for
incrementally verifying the secpath entries associated with it.
next reply other threads:[~2022-08-10 18:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 18:22 Benedict Wong [this message]
2022-08-10 18:22 ` [PATCH ipsec 1/2] xfrm: Check policy for nested XFRM packets in xfrm_input Benedict Wong
2022-08-15 8:45 ` Steffen Klassert
[not found] ` <CANrj0baLB5a5QpdmmcNYZLyxe1r0gySLhT3krXVFXKOzBb8aww@mail.gmail.com>
2022-08-16 8:53 ` Steffen Klassert
2022-08-10 18:22 ` [PATCH ipsec 2/2] xfrm: Skip checking of already-verified secpath entries Benedict Wong
2022-08-15 8:50 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810182210.721493-1-benedictwong@google.com \
--to=benedictwong@google.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=nharold@google.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox