From: "Eugenio Pérez" <eperezma@redhat.com>
To: virtualization@lists.linux-foundation.org,
Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Cc: ecree.xilinx@gmail.com, gautam.dawar@amd.com,
Zhang Min <zhang.min9@zte.com.cn>,
pabloc@xilinx.com, Piotr.Uminski@intel.com,
Dan Carpenter <dan.carpenter@oracle.com>,
tanuj.kamde@amd.com, Zhu Lingshan <lingshan.zhu@intel.com>,
martinh@xilinx.com,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
lvivier@redhat.com, martinpo@xilinx.com, hanand@xilinx.com,
Eli Cohen <elic@nvidia.com>,
lulu@redhat.com, habetsm.xilinx@gmail.com,
Parav Pandit <parav@nvidia.com>, Longpeng <longpeng2@huawei.com>,
Wu Zongyong <wuzongyong@linux.alibaba.com>,
Si-Wei Liu <si-wei.liu@oracle.com>,
Stefano Garzarella <sgarzare@redhat.com>,
dinang@xilinx.com, Xie Yongji <xieyongji@bytedance.com>
Subject: [PATCH v8 2/3] vdpa: Remove wrong doc of VHOST_VDPA_SUSPEND ioctl
Date: Thu, 11 Aug 2022 15:53:52 +0200 [thread overview]
Message-ID: <20220811135353.2549658-3-eperezma@redhat.com> (raw)
In-Reply-To: <20220811135353.2549658-1-eperezma@redhat.com>
It was a leftover from previous versions.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
include/linux/vdpa.h | 2 +-
include/uapi/linux/vhost.h | 15 +++++----------
2 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
index d282f464d2f1..6c4e6ea7f7eb 100644
--- a/include/linux/vdpa.h
+++ b/include/linux/vdpa.h
@@ -218,7 +218,7 @@ struct vdpa_map_file {
* @reset: Reset device
* @vdev: vdpa device
* Returns integer: success (0) or error (< 0)
- * @suspend: Suspend or resume the device (optional)
+ * @suspend: Suspend the device (optional)
* @vdev: vdpa device
* Returns integer: success (0) or error (< 0)
* @get_config_size: Get the size of the configuration space includes
diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
index 6d9f45163155..89fcb2afe472 100644
--- a/include/uapi/linux/vhost.h
+++ b/include/uapi/linux/vhost.h
@@ -171,17 +171,12 @@
#define VHOST_VDPA_SET_GROUP_ASID _IOW(VHOST_VIRTIO, 0x7C, \
struct vhost_vring_state)
-/* Suspend or resume a device so it does not process virtqueue requests anymore
+/* Suspend a device so it does not process virtqueue requests anymore
*
- * After the return of ioctl with suspend != 0, the device must finish any
- * pending operations like in flight requests. It must also preserve all the
- * necessary state (the virtqueue vring base plus the possible device specific
- * states) that is required for restoring in the future. The device must not
- * change its configuration after that point.
- *
- * After the return of ioctl with suspend == 0, the device can continue
- * processing buffers as long as typical conditions are met (vq is enabled,
- * DRIVER_OK status bit is enabled, etc).
+ * After the return of ioctl the device must finish any pending operations. It
+ * must also preserve all the necessary state (the virtqueue vring base plus
+ * the possible device specific states) that is required for restoring in the
+ * future. The device must not change its configuration after that point.
*/
#define VHOST_VDPA_SUSPEND _IOW(VHOST_VIRTIO, 0x7D, int)
--
2.31.1
next prev parent reply other threads:[~2022-08-11 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 13:53 [PATCH v8 0/3] Implement vdpasim suspend operation Eugenio Pérez
2022-08-11 13:53 ` [PATCH v8 1/3] vdpa: delete unreachable branch on vdpasim_suspend Eugenio Pérez
2022-08-19 0:55 ` Jason Wang
2022-08-11 13:53 ` Eugenio Pérez [this message]
2022-08-19 0:56 ` [PATCH v8 2/3] vdpa: Remove wrong doc of VHOST_VDPA_SUSPEND ioctl Jason Wang
2022-08-11 13:53 ` [PATCH v8 3/3] vhost: Remove invalid parameter " Eugenio Pérez
2022-08-19 0:57 ` Jason Wang
2022-08-11 13:58 ` [PATCH v8 0/3] Implement vdpasim suspend operation Michael S. Tsirkin
2022-08-11 14:25 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811135353.2549658-3-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=Piotr.Uminski@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=dinang@xilinx.com \
--cc=ecree.xilinx@gmail.com \
--cc=elic@nvidia.com \
--cc=gautam.dawar@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=hanand@xilinx.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=martinh@xilinx.com \
--cc=martinpo@xilinx.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabloc@xilinx.com \
--cc=parav@nvidia.com \
--cc=sgarzare@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=tanuj.kamde@amd.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wuzongyong@linux.alibaba.com \
--cc=xieyongji@bytedance.com \
--cc=zhang.min9@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).