From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
Michal Jaron <michalx.jaron@intel.com>,
netdev@vger.kernel.org,
Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
Marek Szlosek <marek.szlosek@intel.com>
Subject: Re: [PATCH net 2/2] ice: Fix call trace with null VSI during VF reset
Date: Fri, 12 Aug 2022 17:13:19 -0700 [thread overview]
Message-ID: <20220812171319.495e33f5@kernel.org> (raw)
In-Reply-To: <20220811161714.305094-3-anthony.l.nguyen@intel.com>
On Thu, 11 Aug 2022 09:17:14 -0700 Tony Nguyen wrote:
> This WARN_ON() is unnecessary and causes call trace, despite that
> call trace, driver still works. There is no need for this warn
> because this piece of code is responsible for disabling VF's Tx/Rx
> queues when VF is disabled, but when VF is already removed there
> is no need to do reset or disable queues.
Can't you flush the service work when disabling VFs instead?
Seems better to try to keep the system in a consistent state
than add "if NULL return;" in random places :S
next prev parent reply other threads:[~2022-08-13 0:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 16:17 [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2022-08-11 (ice) Tony Nguyen
2022-08-11 16:17 ` [PATCH net 1/2] ice: Fix VSI rebuild WARN_ON check for VF Tony Nguyen
2022-08-11 16:17 ` [PATCH net 2/2] ice: Fix call trace with null VSI during VF reset Tony Nguyen
2022-08-13 0:13 ` Jakub Kicinski [this message]
2022-08-17 13:31 ` Sokolowski, Jan
2022-08-17 15:47 ` Jakub Kicinski
2022-08-15 10:40 ` [PATCH net 0/2][pull request] Intel Wired LAN Driver Updates 2022-08-11 (ice) patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220812171319.495e33f5@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jedrzej.jagielski@intel.com \
--cc=marek.szlosek@intel.com \
--cc=michalx.jaron@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).