From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55841C25B0E for ; Mon, 15 Aug 2022 15:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242833AbiHOPTL (ORCPT ); Mon, 15 Aug 2022 11:19:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240609AbiHOPTI (ORCPT ); Mon, 15 Aug 2022 11:19:08 -0400 Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74D032657E; Mon, 15 Aug 2022 08:19:07 -0700 (PDT) Received: by mail-vs1-xe29.google.com with SMTP id k2so7433285vsk.8; Mon, 15 Aug 2022 08:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=c3j08WjbeBArCk0Y4zDetUFNhfLRW0Osm6JLlAMKNr8=; b=W5zZiwP4MPORZqW9J9Q/aCZW8FAF5s/EkQTgFpzGMMC8fP6A5EV3pZzruglUvmL1Iz h17BKmeKLo2GqpbxEcPjMhZfetwrymnP+n6Z6csGUwGA+OeDplt+Z0B+mYX9M4Qsu+uF 5B56Hoo468KdcNLzsTKHOui4j5B38GwK9V34hXo9EQQqx9PYvp2Y8ODY+mYdLQuv1qYP 1bDrKqGb8Zw/43rIQuVT0PVJrNwQJzaG9N/Bm6mUKjQ2v07hXJpzArzeafqrW5STfJ1s l2W6OAzuL6bp40bOJXJrJ9isUi+iGOJe5rLp8JixGdokDGJFNDlyN4W1+dypQJgEAQV2 cRKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=c3j08WjbeBArCk0Y4zDetUFNhfLRW0Osm6JLlAMKNr8=; b=P4vZPfSgdSbwbwp6aF/HIitnU/lrHrdxHXfCblaRu0mtElDevwxOiodbnFPT5YFzrV uHK+bj4JN40JEsTW7vySc66Yk49+stjuzuywSLaRcKCFMQ43hNOFw4QUbACvy3Sr5LEY 2xpazsCqJqeG5Dc8yt/HSy2ownzg7b8Ub/s7xmDKDnbFnq6uY2J08/7oIoJ5Lx54fyOk xdZ4UX8BMiRS8ypg1ULsYo+lYvDwL34ul55sBmaRYG08nF1KGO5og1fjWpPFLBpy0/vf 5VRmZ3o9ke/izY04kBSm06zCk6ASV0piZ59gHto74j5onu36Mm9lS42C1oOrIdYfwH3C zMbA== X-Gm-Message-State: ACgBeo3ytBj0tloUH6u9w3dRaOqT0Zwnv2U2CDxB8Ej+hR5FQltsaopD 8WQ6uSp1b3C3CKVGYqEP5T8IIGjCvo+sp96o X-Google-Smtp-Source: AA6agR6XlFgTjwFbIhG3FFPk6NP5IEgsYr4o/yy7iyzi91cuUlfJm4Uc1JWhKCKmubWC4BJ5Grv1NQ== X-Received: by 2002:a67:d487:0:b0:385:1a6b:6f33 with SMTP id g7-20020a67d487000000b003851a6b6f33mr6548801vsj.59.1660576746592; Mon, 15 Aug 2022 08:19:06 -0700 (PDT) Received: from laptop.. ([2804:14c:71:8fe6:44c:4bb9:384e:eda5]) by smtp.gmail.com with ESMTPSA id m2-20020a672602000000b0038ab671b8afsm4078943vsm.16.2022.08.15.08.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 08:19:06 -0700 (PDT) From: Jose Alonso To: "David S . Miller" , Greg Kroah-Hartman Cc: netdev , stable , Ronald Wahl , Jakub Kicinski , Jose Alonso Subject: [PATCH stable 4.14.x] Revert "net: usb: ax88179_178a needs FLAG_SEND_ZLP" Date: Mon, 15 Aug 2022 12:19:01 -0300 Message-Id: <20220815151901.319130-1-joalonsof@gmail.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org commit 6fd2c17fb6e02a8c0ab51df1cfec82ce96b8e83d upstream. This reverts commit 36a15e1cb134c0395261ba1940762703f778438c. The usage of FLAG_SEND_ZLP causes problems to other firmware/hardware versions that have no issues. The FLAG_SEND_ZLP is not safe to use in this context. See: https://patchwork.ozlabs.org/project/netdev/patch/1270599787.8900.8.camel@Linuxdev4-laptop/#118378 The original problem needs another way to solve. Fixes: 36a15e1cb134 ("net: usb: ax88179_178a needs FLAG_SEND_ZLP") Cc: stable@vger.kernel.org Reported-by: Ronald Wahl Link: https://bugzilla.kernel.org/show_bug.cgi?id=216327 Link: https://bugs.archlinux.org/task/75491 Signed-off-by: Jose Alonso Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/ax88179_178a.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 6d68f9799ada..8a48df80b59a 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1707,7 +1707,7 @@ static const struct driver_info ax88179_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1720,7 +1720,7 @@ static const struct driver_info ax88178a_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1733,7 +1733,7 @@ static const struct driver_info cypress_GX3_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1746,7 +1746,7 @@ static const struct driver_info dlink_dub1312_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1759,7 +1759,7 @@ static const struct driver_info sitecom_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1772,7 +1772,7 @@ static const struct driver_info samsung_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1785,7 +1785,7 @@ static const struct driver_info lenovo_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; @@ -1798,7 +1798,7 @@ static const struct driver_info belkin_info = { .link_reset = ax88179_link_reset, .reset = ax88179_reset, .stop = ax88179_stop, - .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_SEND_ZLP, + .flags = FLAG_ETHER | FLAG_FRAMING_AX, .rx_fixup = ax88179_rx_fixup, .tx_fixup = ax88179_tx_fixup, }; -- 2.37.1