From: Jakub Kicinski <kuba@kernel.org>
To: Sergei Antonov <saproj@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Pavel Skripkin <paskripkin@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jonas Jensen <jonas.jensen@gmail.com>
Subject: Re: [PATCH v2] net: moxa: pass pdev instead of ndev to DMA functions
Date: Mon, 15 Aug 2022 19:56:31 -0700 [thread overview]
Message-ID: <20220815195631.1ca64b3d@kernel.org> (raw)
In-Reply-To: <20220812171339.2271788-1-saproj@gmail.com>
On Fri, 12 Aug 2022 20:13:39 +0300 Sergei Antonov wrote:
> dma_map_single() calls fail in moxart_mac_setup_desc_ring() and
> moxart_mac_start_xmit() which leads to an incessant output of this:
>
> [ 16.043925] moxart-ethernet 92000000.mac eth0: DMA mapping error
> [ 16.050957] moxart-ethernet 92000000.mac eth0: DMA mapping error
> [ 16.058229] moxart-ethernet 92000000.mac eth0: DMA mapping error
>
> Passing pdev to DMA is a common approach among net drivers.
Thanks! I slapped
Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver")
on it when applying, please make sure to provide Fixes tags in
the future (and CC authors so they can review).
next prev parent reply other threads:[~2022-08-16 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 17:13 [PATCH v2] net: moxa: pass pdev instead of ndev to DMA functions Sergei Antonov
2022-08-12 17:56 ` Andrew Lunn
2022-08-16 2:56 ` Jakub Kicinski [this message]
2022-08-16 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220815195631.1ca64b3d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jonas.jensen@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paskripkin@gmail.com \
--cc=saproj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).