From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <david.laight@aculab.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>,
<netdev@vger.kernel.org>, <tkhai@ya.ru>,
<viro@zeniv.linux.org.uk>
Subject: RE: [PATCH v2 1/2] fs: Export __receive_fd()
Date: Tue, 16 Aug 2022 10:15:09 -0700 [thread overview]
Message-ID: <20220816171509.98183-1-kuniyu@amazon.com> (raw)
In-Reply-To: <e3e2fe6a2b8f4a65a4e28d9d7fddd558@AcuMS.aculab.com>
From: David Laight <David.Laight@ACULAB.COM>
Date: Tue, 16 Aug 2022 08:03:14 +0000
> From: Kirill Tkhai
> > Sent: 15 August 2022 22:15
> >
> > This is needed to make receive_fd_user() available in modules, and it will be used in next patch.
> >
> > Signed-off-by: Kirill Tkhai <tkhai@ya.ru>
> > ---
> > v2: New
> > fs/file.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/file.c b/fs/file.c
> > index 3bcc1ecc314a..e45d45f1dd45 100644
> > --- a/fs/file.c
> > +++ b/fs/file.c
> > @@ -1181,6 +1181,7 @@ int __receive_fd(struct file *file, int __user *ufd, unsigned int o_flags)
> > __receive_sock(file);
> > return new_fd;
> > }
> > +EXPORT_SYMBOL_GPL(__receive_fd);
>
> It doesn't seem right (to me) to be exporting a function
> with a __ prefix.
+1.
Now receive_fd() has inline and it's the problem.
Can we avoid this by moving receive_fd() in fs/file.c without inline and
exporting it?
next prev parent reply other threads:[~2022-08-16 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 21:13 [PATCH v2 0/2] unix: Add ioctl(SIOCUNIXGRABFDS) to grab files of receive queue skbs Kirill Tkhai
2022-08-15 21:15 ` [PATCH v2 1/2] fs: Export __receive_fd() Kirill Tkhai
2022-08-16 8:03 ` David Laight
2022-08-16 17:15 ` Kuniyuki Iwashima [this message]
2022-08-16 17:29 ` David Laight
2022-08-16 17:42 ` Kuniyuki Iwashima
2022-08-16 21:59 ` Kirill Tkhai
2022-08-15 21:22 ` [PATCH v2 2/2] af_unix: Add ioctl(SIOCUNIXGRABFDS) to grab files of receive queue skbs Kirill Tkhai
2022-08-16 17:31 ` Kuniyuki Iwashima
2022-08-16 22:08 ` Kirill Tkhai
2022-08-15 21:42 ` [PATCH v2 1/2] fs: Export __receive_fd() Kirill Tkhai
2022-08-15 21:45 ` [PATCH v2 2/2] af_unix: Add ioctl(SIOCUNIXGRABFDS) to grab files of receive queue skbs Kirill Tkhai
2022-08-16 17:42 ` [PATCH v2 0/2] unix: " Al Viro
2022-08-16 21:55 ` Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816171509.98183-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=david.laight@aculab.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=tkhai@ya.ru \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).