From: Stephen Hemminger <stephen@networkplumber.org>
To: jiangheng <15720603159@163.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] genl: modify the command output message of genl -h
Date: Tue, 16 Aug 2022 19:06:23 -0700 [thread overview]
Message-ID: <20220816190623.6cb655c3@hermes.local> (raw)
In-Reply-To: <1c6b71b1.62fc.18290edbaff.Coremail.15720603159@163.com>
On Fri, 12 Aug 2022 15:21:15 +0800 (CST)
jiangheng <15720603159@163.com> wrote:
> From f4709a324870822066b449bab89980dba8c8af79 Mon Sep 17 00:00:00 2001
> From: jinag <jinag12138@gmail.com>
> Date: Thu, 14 Oct 2021 15:13:03 +0800
> Subject: [PATCH] genl: modify the command output of genl -h
>
> after the modification, the command output is the same as that of man 8 genl and more readable.
iproute2 follows the kernel style and contribution rules.
This patch has multiple issues
$ checkpatch.pl ~/Downloads/iproute2-genl-modify-the-command-output-message-of-genl--h.patch
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#58:
after the modification, the command output is the same as that of man 8 genl and more readable.
ERROR: code indent should use tabs where possible
#77: FILE: genl/genl.c:102:
+ "Usage: genl [ OPTIONS ] OBJECT [help]\n"$
WARNING: please, no spaces at the start of a line
#77: FILE: genl/genl.c:102:
+ "Usage: genl [ OPTIONS ] OBJECT [help]\n"$
ERROR: code indent should use tabs where possible
#78: FILE: genl/genl.c:103:
+ "where OBJECT := { ctrl CTRL_OPTS }\n"$
WARNING: please, no spaces at the start of a line
#78: FILE: genl/genl.c:103:
+ "where OBJECT := { ctrl CTRL_OPTS }\n"$
ERROR: code indent should use tabs where possible
#79: FILE: genl/genl.c:104:
+ " OPTIONS := { -s[tatistics] | -d[etails] | -r[aw] | -V[ersion] | -h[elp] }\n"$
WARNING: please, no spaces at the start of a line
#79: FILE: genl/genl.c:104:
+ " OPTIONS := { -s[tatistics] | -d[etails] | -r[aw] | -V[ersion] | -h[elp] }\n"$
ERROR: code indent should use tabs where possible
#80: FILE: genl/genl.c:105:
+ " CTRL_OPTS := { help | list | monitor | get PARMS }\n"$
WARNING: please, no spaces at the start of a line
#80: FILE: genl/genl.c:105:
+ " CTRL_OPTS := { help | list | monitor | get PARMS }\n"$
ERROR: code indent should use tabs where possible
#81: FILE: genl/genl.c:106:
+ " PARMS := { name NAME | id ID }\n");$
WARNING: please, no spaces at the start of a line
#81: FILE: genl/genl.c:106:
+ " PARMS := { name NAME | id ID }\n");$
ERROR: Missing Signed-off-by: line(s)
prev parent reply other threads:[~2022-08-17 2:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 7:21 [PATCH iproute2] genl: modify the command output message of genl -h jiangheng
2022-08-17 2:06 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816190623.6cb655c3@hermes.local \
--to=stephen@networkplumber.org \
--cc=15720603159@163.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox