From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C85C2BB41 for ; Wed, 17 Aug 2022 08:55:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234680AbiHQIzp (ORCPT ); Wed, 17 Aug 2022 04:55:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233930AbiHQIzn (ORCPT ); Wed, 17 Aug 2022 04:55:43 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D3B27F254 for ; Wed, 17 Aug 2022 01:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660726541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kxXD+nXe69utb78dojqgzjisp1/GKHU9/l3M8qyZRmc=; b=E0HWELluDiboUHnUpv8RCJyrGyu+UYRtSxx2BuFjTSUeQ0ntplx8i0OC9LAIXplB7zAk00 YW2tnf5LxETkKEQm737UnJVXS3+3jJ5ATc39LZkJ7GG/2INK5kVJBPtSGPJZ8Mo1zIbH+c vPLghqysyXEU1dOnHjK9yntEzh1PyRA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-267-Gx_0oUEGPZCCOoM-I0vCqw-1; Wed, 17 Aug 2022 04:55:40 -0400 X-MC-Unique: Gx_0oUEGPZCCOoM-I0vCqw-1 Received: by mail-wm1-f70.google.com with SMTP id b16-20020a05600c4e1000b003a5a47762c3so6070220wmq.9 for ; Wed, 17 Aug 2022 01:55:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=kxXD+nXe69utb78dojqgzjisp1/GKHU9/l3M8qyZRmc=; b=iaJjaJ5uoDFIXUUMooPQzS7P2jXDFTLawzTU1Aqf+jweZWXVk9ZrbkQc9hxeG4OcqX C5TROXyhIyoLziAOIoaRZ2GVE20fieODMngfumbdFRakHdHeg1GnxBX0gVZL8MXZjsMY 1VhcyN+jVdvKg/xQykYsapsYIw2Nmm9hcvzK4Wvs7nuWKPkNPtZTfXa2D4sdQD+PR2wn RDQUvX/mbiFYWekI3OIimNmjSXEV86quVkIBw71uUYZyGFBIBeBO/Z1QwyHYstVy6TSl dK3xnd/GP09T6SXIgzHZCsGwyVEsW2LkJhGyiYBbxoDhMaoXzWzkRY7n6xD5HHFb030F /ttQ== X-Gm-Message-State: ACgBeo2zbTMTI1AnLg3PaAsRU7MmcNIvPOgq9M/+xEr40BAKvsMMnRpD M3BGCaNaxeTjELG+ihQIoi76wIBXfLqlhv9kZ59Lc489jm76FrG/oZS7iS1RDjBXZWba7Mg/RMa dTUva8YtVlCZGp+zT X-Received: by 2002:a05:600c:1d9b:b0:3a5:d66e:6370 with SMTP id p27-20020a05600c1d9b00b003a5d66e6370mr1433273wms.73.1660726539047; Wed, 17 Aug 2022 01:55:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR6joZazkqh/7hPdngPGw0ZOIMJpCoIUyVh/yzbAhFI1ASubyybt/XwdZKSVEcy82NUPWtkj5Q== X-Received: by 2002:a05:600c:1d9b:b0:3a5:d66e:6370 with SMTP id p27-20020a05600c1d9b00b003a5d66e6370mr1433257wms.73.1660726538821; Wed, 17 Aug 2022 01:55:38 -0700 (PDT) Received: from redhat.com ([2.55.4.37]) by smtp.gmail.com with ESMTPSA id bn21-20020a056000061500b0021e43b4edf0sm12352740wrb.20.2022.08.17.01.55.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 01:55:37 -0700 (PDT) Date: Wed, 17 Aug 2022 04:55:32 -0400 From: "Michael S. Tsirkin" To: "Zhu, Lingshan" Cc: Si-Wei Liu , jasowang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, parav@nvidia.com, xieyongji@bytedance.com, gautam.dawar@amd.com Subject: Re: [PATCH 2/2] vDPA: conditionally read fields in virtio-net dev Message-ID: <20220817045406-mutt-send-email-mst@kernel.org> References: <20220815092638.504528-1-lingshan.zhu@intel.com> <20220815092638.504528-3-lingshan.zhu@intel.com> <20e92551-a639-ec13-3d9c-13bb215422e1@intel.com> <9b6292f3-9bd5-ecd8-5e42-cd5d12f036e7@oracle.com> <22e0236f-b556-c6a8-0043-b39b02928fd6@intel.com> <892b39d6-85f8-bff5-030d-e21288975572@oracle.com> <52a47bc7-bf26-b8f9-257f-7dc5cea66d23@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52a47bc7-bf26-b8f9-257f-7dc5cea66d23@intel.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 17, 2022 at 10:14:26AM +0800, Zhu, Lingshan wrote: > Yes it is a little messy, and we can not check _F_VERSION_1 because of > transitional devices, so maybe this is the best we can do for now I think vhost generally needs an API to declare config space endian-ness to kernel. vdpa can reuse that too then. -- MST