From: Jakub Kicinski <kuba@kernel.org>
To: chris.chenfeiyang@gmail.com
Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
joabreu@synopsys.com, Feiyang Chen <chenfeiyang@loongson.cn>,
zhangqing@loongson.cn, chenhuacai@loongson.cn,
netdev@vger.kernel.org, loongarch@lists.linux.dev
Subject: Re: [PATCH v2 1/2] stmmac: Expose module parameters
Date: Wed, 17 Aug 2022 20:05:49 -0700 [thread overview]
Message-ID: <20220817200549.392b5891@kernel.org> (raw)
In-Reply-To: <5bf66e7d30d909cdaad46557d800d33118404e4d.1660720671.git.chenfeiyang@loongson.cn>
On Wed, 17 Aug 2022 15:29:18 +0800 chris.chenfeiyang@gmail.com wrote:
> Expose module parameters so that we can use them in specific device
> configurations. Add the 'stmmac_' prefix for them to avoid conflicts.
>
> Meanwhile, there was a 'buf_sz' local variable in stmmac_rx() with the
> same name as the global variable, and now we can distinguish them.
Can you provide more information on the 'why'?
next prev parent reply other threads:[~2022-08-18 3:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1660720671.git.chenfeiyang@loongson.cn>
2022-08-17 7:29 ` [PATCH v2 1/2] stmmac: Expose module parameters chris.chenfeiyang
2022-08-18 3:05 ` Jakub Kicinski [this message]
2022-08-18 6:41 ` Feiyang Chen
2022-08-18 12:15 ` Andrew Lunn
2022-08-17 7:29 ` [PATCH v2 2/2] stmmac: pci: Add LS7A support for dwmac-loongson chris.chenfeiyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817200549.392b5891@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@loongson.cn \
--cc=chris.chenfeiyang@gmail.com \
--cc=joabreu@synopsys.com \
--cc=loongarch@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).