From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12257C00140 for ; Thu, 18 Aug 2022 17:22:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345019AbiHRRWQ (ORCPT ); Thu, 18 Aug 2022 13:22:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343766AbiHRRVo (ORCPT ); Thu, 18 Aug 2022 13:21:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FE586570; Thu, 18 Aug 2022 10:20:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2C6FAB82305; Thu, 18 Aug 2022 17:20:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F875C433D6; Thu, 18 Aug 2022 17:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660843232; bh=EXNuPGYk5JyIPmHakPo7fo+5V311YmG09WDtES+EREg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jTXuot/kf+sZsttKzZZJ5b71mGqt3hh6B+SlVMAtpPxmGld0u3bYrMvfjqDWwOhNC XVuBSXA5tMCbYeXx7v16OWB9kuU4IWn0H5rDodcULaVGCRR2z2bRIGP2d/gY8I+V6i ABXIyh9vYJUCkk3zEU5eEcL+3soiNNYXJrpTbWmteyyJaQzYQrRsJyZg+vcgJ1HeYn nP9qL8ZheensvzT0pLmAcYHuEQWRAQ7aON/vHoI5x4Bo9eld3lq4QbHG+YkQHStkeS YX3QswabGngKZNuEM+/Cj9Dl+2VlG5MemBsKWmXGM7YQP1f8/nw55gUWw+xCV5VJgZ vgRUot5GgoriQ== Date: Thu, 18 Aug 2022 10:20:31 -0700 From: Jakub Kicinski To: Christophe JAILLET Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Joakim Zhang , Andrew Lunn , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Shevchenko , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/2] stmmac: intel: Add a missing clk_disable_unprepare() call in intel_eth_pci_remove() Message-ID: <20220818102031.5be300f5@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 16 Aug 2022 16:23:57 +0200 Christophe JAILLET wrote: > Commit 09f012e64e4b ("stmmac: intel: Fix clock handling on error and remove > paths") removed this clk_disable_unprepare() > > This was partly revert by commit ac322f86b56c ("net: stmmac: Fix clock > handling on remove path") which removed this clk_disable_unprepare() > because: I'll take patch 1 in now, please repost patch two in a few hours after Linus pull net (or just tomorrow if you don't wanna try to track it down). Please avoid posting fixes and cleanups in a single series. They go via different trees.