* [PATCH net] net: ethernet: altera: Add use of ethtool_op_get_ts_info
@ 2022-08-17 9:57 Maxime Chevallier
2022-08-18 17:26 ` Jakub Kicinski
2022-08-18 17:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Maxime Chevallier @ 2022-08-17 9:57 UTC (permalink / raw)
To: davem
Cc: Maxime Chevallier, netdev, linux-kernel, thomas.petazzoni,
Richard Cochran, Joyce Ooi, Jakub Kicinski, Eric Dumazet,
Paolo Abeni
Add the ethtool_op_get_ts_info() callback to ethtool ops, so that we can
at least use software timestamping.
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
drivers/net/ethernet/altera/altera_tse_ethtool.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/altera/altera_tse_ethtool.c b/drivers/net/ethernet/altera/altera_tse_ethtool.c
index 4299f1301149..3081e5874ac5 100644
--- a/drivers/net/ethernet/altera/altera_tse_ethtool.c
+++ b/drivers/net/ethernet/altera/altera_tse_ethtool.c
@@ -233,6 +233,7 @@ static const struct ethtool_ops tse_ethtool_ops = {
.set_msglevel = tse_set_msglevel,
.get_link_ksettings = phy_ethtool_get_link_ksettings,
.set_link_ksettings = phy_ethtool_set_link_ksettings,
+ .get_ts_info = ethtool_op_get_ts_info,
};
void altera_tse_set_ethtool_ops(struct net_device *netdev)
--
2.37.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] net: ethernet: altera: Add use of ethtool_op_get_ts_info
2022-08-17 9:57 [PATCH net] net: ethernet: altera: Add use of ethtool_op_get_ts_info Maxime Chevallier
@ 2022-08-18 17:26 ` Jakub Kicinski
2022-08-18 17:31 ` Maxime Chevallier
2022-08-18 17:40 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2022-08-18 17:26 UTC (permalink / raw)
To: Maxime Chevallier
Cc: davem, netdev, linux-kernel, thomas.petazzoni, Richard Cochran,
Joyce Ooi, Eric Dumazet, Paolo Abeni
On Wed, 17 Aug 2022 11:57:25 +0200 Maxime Chevallier wrote:
> Add the ethtool_op_get_ts_info() callback to ethtool ops, so that we can
> at least use software timestamping.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
I think our definition of bug is too narrow to fit this. It falls into
"never worked" category AFAICT so to net-next it goes.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: ethernet: altera: Add use of ethtool_op_get_ts_info
2022-08-18 17:26 ` Jakub Kicinski
@ 2022-08-18 17:31 ` Maxime Chevallier
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Chevallier @ 2022-08-18 17:31 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, netdev, linux-kernel, thomas.petazzoni, Richard Cochran,
Joyce Ooi, Eric Dumazet, Paolo Abeni
Hello Jakub,
On Thu, 18 Aug 2022 10:26:56 -0700
Jakub Kicinski <kuba@kernel.org> wrote:
> On Wed, 17 Aug 2022 11:57:25 +0200 Maxime Chevallier wrote:
> > Add the ethtool_op_get_ts_info() callback to ethtool ops, so that
> > we can at least use software timestamping.
> >
> > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
>
> I think our definition of bug is too narrow to fit this. It falls into
> "never worked" category AFAICT so to net-next it goes.
My bad, I actually meant to target it to net-next, that was a silly
mistake from me...
Do I need to resend ?
Best regards,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: ethernet: altera: Add use of ethtool_op_get_ts_info
2022-08-17 9:57 [PATCH net] net: ethernet: altera: Add use of ethtool_op_get_ts_info Maxime Chevallier
2022-08-18 17:26 ` Jakub Kicinski
@ 2022-08-18 17:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-08-18 17:40 UTC (permalink / raw)
To: Maxime Chevallier
Cc: davem, netdev, linux-kernel, thomas.petazzoni, richardcochran,
joyce.ooi, kuba, edumazet, pabeni
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 17 Aug 2022 11:57:25 +0200 you wrote:
> Add the ethtool_op_get_ts_info() callback to ethtool ops, so that we can
> at least use software timestamping.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> drivers/net/ethernet/altera/altera_tse_ethtool.c | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- [net] net: ethernet: altera: Add use of ethtool_op_get_ts_info
https://git.kernel.org/netdev/net-next/c/fb8d784b531e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-18 17:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-17 9:57 [PATCH net] net: ethernet: altera: Add use of ethtool_op_get_ts_info Maxime Chevallier
2022-08-18 17:26 ` Jakub Kicinski
2022-08-18 17:31 ` Maxime Chevallier
2022-08-18 17:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).