netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 9/9] u64_stat: Remove the obsolete fetch_irq() variants
Date: Thu, 18 Aug 2022 10:45:05 -0700	[thread overview]
Message-ID: <20220818104505.010ff950@kernel.org> (raw)
In-Reply-To: <Yv5v1E6mfpcxjnLV@linutronix.de>

On Thu, 18 Aug 2022 18:59:00 +0200 Sebastian Andrzej Siewior wrote:
> On 2022-08-18 09:02:00 [-0700], Jakub Kicinski wrote:
> > No ack, I'd much rather you waited for after the next merge window 
> > and queued this refactoring to net-next. Patch 9 is changing 70
> > files in networking. Unless I'm missing something and this is time
> > sensitive.  
> 
> It started with the clean up of the mess that has been made in the merge
> and then it went on a little.
> 
> Any opinion on 8/9? It could wait for the next merge window if you want
> to avoid a feature branch to pull from.

A question of priority, hard for me to judge how urgent any of it is.
But practically speaking the chances of a conflict on that one header
are pretty small, so ack if needed.

> Regarding 9/9. This is a clean up, which is possible after 8/9. It can
> definitely be applied later.
> I assume you want only see the networking bits so I would split the
> other subsystem out. I guess instead the big net patch I split them on
> per driver vendor basis + net/ subsys?

Oh, don't care for per vendor split on a big refactoring like that.
You can split out the SPI patch and maybe BPF, the rest can be one 
big chunk AFAICT.

BTW, I have a hazy memory of people saying they switched to the _irq()
version because it reduced the number of retries significantly under
traffic. Dunno how practical that is but would you be willing to scan
the git history to double check that's not some of the motivation?

  reply	other threads:[~2022-08-18 17:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220817162703.728679-1-bigeasy@linutronix.de>
2022-08-17 16:27 ` [PATCH 8/9] u64_stats: Streamline the implementation Sebastian Andrzej Siewior
2022-08-17 16:27 ` [PATCH 9/9] u64_stat: Remove the obsolete fetch_irq() variants Sebastian Andrzej Siewior
2022-08-17 18:27   ` Jakub Kicinski
2022-08-18 15:27     ` Sebastian Andrzej Siewior
2022-08-18 16:02       ` Jakub Kicinski
2022-08-18 16:59         ` Sebastian Andrzej Siewior
2022-08-18 17:45           ` Jakub Kicinski [this message]
2022-08-22 15:17             ` Sebastian Andrzej Siewior
2022-08-22 18:05               ` Jakub Kicinski
2022-08-25 16:45                 ` Sebastian Andrzej Siewior
2022-08-25 17:30                   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220818104505.010ff950@kernel.org \
    --to=kuba@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).