From: Jakub Kicinski <kuba@kernel.org>
To: Lior Nahmanson <liorna@nvidia.com>
Cc: <edumazet@google.com>, <pabeni@redhat.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, Raed Salem <raeds@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH 1/3] net/macsec: Add MACsec skb_metadata_dst Tx Data path support
Date: Thu, 18 Aug 2022 21:08:56 -0700 [thread overview]
Message-ID: <20220818210856.30353616@kernel.org> (raw)
In-Reply-To: <20220818132411.578-2-liorna@nvidia.com>
On Thu, 18 Aug 2022 16:24:09 +0300 Lior Nahmanson wrote:
> In the current MACsec offload implementation, MACsec interfaces shares
> the same MAC address by default.
> Therefore, HW can't distinguish from which MACsec interface the traffic
> originated from.
>
> MACsec stack will use skb_metadata_dst to store the SCI value, which is
> unique per MACsec interface, skb_metadat_dst will be used later by the
> offloading device driver to associate the SKB with the corresponding
> offloaded interface (SCI) to facilitate HW MACsec offload.
struct macsec_tx_sc has a kdoc so you need to document the new field (md_dst).
On a quick (sorry we're behind on patches this week) look I don't see
the driver integration - is it coming later? Or there's already somehow
a driver in the tree using this infra? Normally the infra should be in
the same patchset as the in-tree user.
Last thing - please CC some of the folks who worked on MACsec in the
past, so we can get expert reviews, Antoine and Sabrina come to mind,
look thru the git history please.
next prev parent reply other threads:[~2022-08-19 4:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 13:24 [PATCH net-next 00/3] Introduce MACsec skb_metadata_dst Lior Nahmanson
2022-08-18 13:24 ` [PATCH 1/3] net/macsec: Add MACsec skb_metadata_dst Tx Data path support Lior Nahmanson
2022-08-19 4:08 ` Jakub Kicinski [this message]
2022-08-21 11:12 ` Raed Salem
2022-08-22 18:10 ` Jakub Kicinski
2022-08-22 20:29 ` Saeed Mahameed
2022-08-18 13:24 ` [PATCH 2/3] net/macsec: Add MACsec skb_metadata_dst Rx " Lior Nahmanson
2022-08-18 13:24 ` [PATCH 3/3] net/macsec: Move some code for sharing with various drivers that implements offload Lior Nahmanson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818210856.30353616@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=liorna@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raeds@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).