netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: netdev@vger.kernel.org
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Siva Reddy Kallam <siva.kallam@broadcom.com>,
	Prashant Sreedharan <prashant@broadcom.com>,
	Michael Chan <mchan@broadcom.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Salil Mehta <salil.mehta@huawei.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Tariq Toukan <tariqt@nvidia.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Leon Romanovsky <leon@kernel.org>,
	Bryan Whitehead <bryan.whitehead@microchip.com>,
	Sergey Shtylyov <s.shtylyov@omp.ru>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Vivek Thampi <vithampi@vmware.com>,
	VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
	Jie Wang <wangjie125@huawei.com>,
	Guangbin Huang <huangguangbin2@huawei.com>,
	Eran Ben Elisha <eranbe@nvidia.com>, Aya Levin <ayal@nvidia.com>,
	Cai Huoqing <cai.huoqing@linux.dev>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Phil Edworthy <phil.edworthy@renesas.com>,
	Jiasheng Jiang <jiasheng@iscas.ac.cn>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Wan Jiabing <wanjiabing@vivo.com>, Lv Ruyi <lv.ruyi@zte.com.cn>,
	Arnd Bergmann <arnd@arndb.de>
Subject: [net-next 12/14] ptp: stmac: convert to .adjfine and adjust_by_scaled_ppm
Date: Thu, 18 Aug 2022 15:27:40 -0700	[thread overview]
Message-ID: <20220818222742.1070935-13-jacob.e.keller@intel.com> (raw)
In-Reply-To: <20220818222742.1070935-1-jacob.e.keller@intel.com>

The stmac implementation of .adjfreq is implemented in terms of a
straight forward "base * ppb / 1 billion" calculation.

Convert this driver to .adjfine and use the adjust_by_scaled_ppm helper
function to perform the calculation of the new addend.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Jose Abreu <joabreu@synopsys.com>
---

I do not have this hardware, and have only compile tested the change.

 .../net/ethernet/stmicro/stmmac/stmmac_ptp.c  | 23 ++++++-------------
 1 file changed, 7 insertions(+), 16 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
index 4d11980dcd64..0d5e6819ee5d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
@@ -15,29 +15,20 @@
  * stmmac_adjust_freq
  *
  * @ptp: pointer to ptp_clock_info structure
- * @ppb: desired period change in parts ber billion
+ * @scaled_ppm: desired period change in scaled parts per million
  *
  * Description: this function will adjust the frequency of hardware clock.
+ *
+ * Scaled parts per million is ppm with a 16-bit binary fractional field.
  */
-static int stmmac_adjust_freq(struct ptp_clock_info *ptp, s32 ppb)
+static int stmmac_adjust_freq(struct ptp_clock_info *ptp, long scaled_ppm)
 {
 	struct stmmac_priv *priv =
 	    container_of(ptp, struct stmmac_priv, ptp_clock_ops);
 	unsigned long flags;
-	u32 diff, addend;
-	int neg_adj = 0;
-	u64 adj;
+	u32 addend;
 
-	if (ppb < 0) {
-		neg_adj = 1;
-		ppb = -ppb;
-	}
-
-	addend = priv->default_addend;
-	adj = addend;
-	adj *= ppb;
-	diff = div_u64(adj, 1000000000ULL);
-	addend = neg_adj ? (addend - diff) : (addend + diff);
+	addend = (u32)adjust_by_scaled_ppm(priv->default_addend, scaled_ppm);
 
 	write_lock_irqsave(&priv->ptp_lock, flags);
 	stmmac_config_addend(priv, priv->ptpaddr, addend);
@@ -269,7 +260,7 @@ static struct ptp_clock_info stmmac_ptp_clock_ops = {
 	.n_per_out = 0, /* will be overwritten in stmmac_ptp_register */
 	.n_pins = 0,
 	.pps = 0,
-	.adjfreq = stmmac_adjust_freq,
+	.adjfine = stmmac_adjust_freq,
 	.adjtime = stmmac_adjust_time,
 	.gettime64 = stmmac_get_time,
 	.settime64 = stmmac_set_time,
-- 
2.37.1.208.ge72d93e88cb2


  parent reply	other threads:[~2022-08-18 22:28 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18 22:27 [net-next 00/14] ptp: convert drivers to .adjfine Jacob Keller
2022-08-18 22:27 ` [net-next 01/14] ptp: add missing documentation for parameters Jacob Keller
2022-08-18 22:27 ` [net-next 02/14] ptp: introduce helpers to adjust by scaled parts per million Jacob Keller
2022-08-18 22:27 ` [net-next 03/14] drivers: convert unsupported .adjfreq to .adjfine Jacob Keller
2022-08-18 22:27 ` [net-next 04/14] ptp_phc: convert to .adjfine and ptp_adj_scaled_ppm Jacob Keller
2022-08-18 22:27 ` [net-next 05/14] ptp_ixp46x: convert to .adjfine and adjust_by_scaled_ppm Jacob Keller
2022-08-18 22:27 ` [net-next 06/14] ptp: tg3: convert to .adjfine and diff_by_scaled_ppm Jacob Keller
2022-08-18 22:27 ` [net-next 07/14] ptp: hclge: convert to .adjfine and adjust_by_scaled_ppm Jacob Keller
2022-08-18 22:27 ` [net-next 08/14] ptp: mlx4: " Jacob Keller
2022-08-18 22:27 ` [net-next 09/14] ptp: mlx5: " Jacob Keller
2022-08-23 15:30   ` Gal Pressman
2022-08-25  6:31     ` Gal Pressman
2022-08-25 21:59     ` Keller, Jacob E
2022-08-18 22:27 ` [net-next 10/14] ptp: lan743x: convert to .adjfine and diff_by_scaled_ppm Jacob Keller
2022-08-19  2:47   ` kernel test robot
2022-08-21 15:22   ` kernel test robot
2022-08-22 17:10     ` Keller, Jacob E
2022-08-18 22:27 ` [net-next 11/14] ptp: ravb: convert to .adjfine and adjust_by_scaled_ppm Jacob Keller
2022-08-20 19:33   ` Sergey Shtylyov
2022-08-22 17:07     ` Keller, Jacob E
2022-08-18 22:27 ` Jacob Keller [this message]
2022-08-18 22:27 ` [net-next 13/14] ptp: cpts: " Jacob Keller
2022-08-18 22:27 ` [net-next 14/14] ptp: xgbe: " Jacob Keller
2022-08-19 16:05   ` Tom Lendacky
2022-08-19 21:04     ` Keller, Jacob E
2022-08-22 20:47       ` Tom Lendacky
2022-08-22 21:11         ` Keller, Jacob E
2022-08-19  7:39 ` [net-next 00/14] ptp: convert drivers to .adjfine Richard Cochran
2022-08-19 20:56   ` Keller, Jacob E
2022-08-23 16:28     ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220818222742.1070935-13-jacob.e.keller@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=arnd@arndb.de \
    --cc=ayal@nvidia.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=bryan.whitehead@microchip.com \
    --cc=cai.huoqing@linux.dev \
    --cc=davem@davemloft.net \
    --cc=decui@microsoft.com \
    --cc=edumazet@google.com \
    --cc=eranbe@nvidia.com \
    --cc=gustavoars@kernel.org \
    --cc=haiyangz@microsoft.com \
    --cc=huangguangbin2@huawei.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=jiasheng@iscas.ac.cn \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=kys@microsoft.com \
    --cc=leon@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=lv.ruyi@zte.com.cn \
    --cc=mchan@broadcom.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peppe.cavallaro@st.com \
    --cc=phil.edworthy@renesas.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=prashant@broadcom.com \
    --cc=pv-drivers@vmware.com \
    --cc=richardcochran@gmail.com \
    --cc=s.shtylyov@omp.ru \
    --cc=saeedm@nvidia.com \
    --cc=salil.mehta@huawei.com \
    --cc=siva.kallam@broadcom.com \
    --cc=sthemmin@microsoft.com \
    --cc=tariqt@nvidia.com \
    --cc=thomas.lendacky@amd.com \
    --cc=vithampi@vmware.com \
    --cc=wangjie125@huawei.com \
    --cc=wanjiabing@vivo.com \
    --cc=wei.liu@kernel.org \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).