From: Jakub Kicinski <kuba@kernel.org>
To: Axel Rasmussen <axelrasmussen@google.com>
Cc: Andrei Vagin <avagin@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>, Jens Axboe <axboe@kernel.dk>,
Kees Cook <keescook@chromium.org>,
Paolo Abeni <pabeni@redhat.com>,
Pavel Begunkov <asml.silence@gmail.com>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests: fix a couple missing .gitignore entries
Date: Fri, 19 Aug 2022 16:07:52 -0700 [thread overview]
Message-ID: <20220819160752.777ef64b@kernel.org> (raw)
In-Reply-To: <20220819190558.477166-1-axelrasmussen@google.com>
On Fri, 19 Aug 2022 12:05:58 -0700 Axel Rasmussen wrote:
> Some recent commits added new test binaries, but forgot to add those to
> .gitignore. Now, after one does "make -C tools/testing/selftests", one
> ends up with some untracked files in the kernel tree.
>
> Add the test binaries to .gitignore, to avoid this minor annoyance.
>
> Fixes: d8b6171bd58a ("selftests/io_uring: test zerocopy send")
> Fixes: 6342140db660 ("selftests/timens: add a test for vfork+exit")
> Signed-off-by: Axel Rasmussen <axelrasmussen@google.com>
> ---
> tools/testing/selftests/net/.gitignore | 3 ++-
> tools/testing/selftests/timens/.gitignore | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/.gitignore b/tools/testing/selftests/net/.gitignore
> index 0e5751af6247..02abf8fdfd3a 100644
> --- a/tools/testing/selftests/net/.gitignore
> +++ b/tools/testing/selftests/net/.gitignore
> @@ -39,4 +39,5 @@ toeplitz
> tun
> cmsg_sender
> unix_connect
> -tap
> \ No newline at end of file
> +tap
> +io_uring_zerocopy_tx
Could you make the io_uring test the first in the file?
That'd gets us closest to the alphabetical ordering (I know the file is
not ordered now, but we should start moving that way).
next prev parent reply other threads:[~2022-08-19 23:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 19:05 [PATCH] selftests: fix a couple missing .gitignore entries Axel Rasmussen
2022-08-19 19:07 ` Kees Cook
2022-08-19 23:07 ` Jakub Kicinski [this message]
2022-08-22 16:17 ` Axel Rasmussen
2022-08-22 18:29 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819160752.777ef64b@kernel.org \
--to=kuba@kernel.org \
--cc=asml.silence@gmail.com \
--cc=avagin@gmail.com \
--cc=axboe@kernel.dk \
--cc=axelrasmussen@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).