Re: [PATCH v2 net-next 8/9] net: mscc: ocelot: set up tag_8021q CPU ports independent of user port affinity

Colin Foster
2022-08-19T13:38:08Z

On Fri, Aug 19, 2022 at 11:06:23AM +0000, Vladimir Oltean wrote:
> On Thu, Aug 18, 2022 at 08:58:56PM -0700, Jakub Kicinski wrote:
> > ERROR: modpost: "ocelot_port_teardown_dsa_8021q_cpu" [drivers/net/dsa/ocelot/mscc_felix.ko] undefined!
> > ERROR: modpost: "ocelot_port_teardown_dsa_8021q_cpu" [drivers/net/dsa/ocelot/mscc_seville.ko] undefined!
>
> Damn, I forgot EXPORT_SYMBOL_GPL()....
> Since I see you've marked the patches as changes requested already, I'll
> go ahead and resubmit.

Any reason not to use the _NS() variants?