* [PATCH] core: Variable type completion
@ 2022-08-17 1:35 Xin Gao
2022-08-19 23:47 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Xin Gao @ 2022-08-17 1:35 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni
Cc: sdf, tj, daniel, ast, netdev, linux-kernel, Xin Gao
'unsigned int' is better than 'unsigned'.
Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
net/core/netclassid_cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/netclassid_cgroup.c b/net/core/netclassid_cgroup.c
index 1a6a86693b74..d6a70aeaa503 100644
--- a/net/core/netclassid_cgroup.c
+++ b/net/core/netclassid_cgroup.c
@@ -66,7 +66,7 @@ struct update_classid_context {
#define UPDATE_CLASSID_BATCH 1000
-static int update_classid_sock(const void *v, struct file *file, unsigned n)
+static int update_classid_sock(const void *v, struct file *file, unsigned int n)
{
struct update_classid_context *ctx = (void *)v;
struct socket *sock = sock_from_file(file);
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] core: Variable type completion
2022-08-17 1:35 [PATCH] core: Variable type completion Xin Gao
@ 2022-08-19 23:47 ` Jakub Kicinski
2022-08-20 0:07 ` Tejun Heo
0 siblings, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2022-08-19 23:47 UTC (permalink / raw)
To: Xin Gao; +Cc: davem, edumazet, pabeni, sdf, tj, daniel, ast, netdev,
linux-kernel
On Wed, 17 Aug 2022 09:35:29 +0800 Xin Gao wrote:
> 'unsigned int' is better than 'unsigned'.
Please resend with the following subject:
[PATCH net-next] net: cgroup: complete unsigned type name
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] core: Variable type completion
2022-08-19 23:47 ` Jakub Kicinski
@ 2022-08-20 0:07 ` Tejun Heo
2022-08-20 0:34 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Tejun Heo @ 2022-08-20 0:07 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Xin Gao, davem, edumazet, pabeni, sdf, daniel, ast, netdev,
linux-kernel
On Fri, Aug 19, 2022 at 04:47:31PM -0700, Jakub Kicinski wrote:
> On Wed, 17 Aug 2022 09:35:29 +0800 Xin Gao wrote:
> > 'unsigned int' is better than 'unsigned'.
>
> Please resend with the following subject:
>
> [PATCH net-next] net: cgroup: complete unsigned type name
Out of curiosity, why is 'unsigned int' better than 'unsigned'?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] core: Variable type completion
2022-08-20 0:07 ` Tejun Heo
@ 2022-08-20 0:34 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-08-20 0:34 UTC (permalink / raw)
To: Tejun Heo, Xin Gao
Cc: davem, edumazet, pabeni, sdf, daniel, ast, netdev, linux-kernel
On Fri, 19 Aug 2022 14:07:26 -1000 Tejun Heo wrote:
> On Fri, Aug 19, 2022 at 04:47:31PM -0700, Jakub Kicinski wrote:
> > On Wed, 17 Aug 2022 09:35:29 +0800 Xin Gao wrote:
> > > 'unsigned int' is better than 'unsigned'.
> >
> > Please resend with the following subject:
> >
> > [PATCH net-next] net: cgroup: complete unsigned type name
>
> Out of curiosity, why is 'unsigned int' better than 'unsigned'?
Good question, a citation in the commit message would also be good.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-20 0:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-17 1:35 [PATCH] core: Variable type completion Xin Gao
2022-08-19 23:47 ` Jakub Kicinski
2022-08-20 0:07 ` Tejun Heo
2022-08-20 0:34 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).