Netdev List
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Sergei Antonov <saproj@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: mv88e6060: NULL dereference in dsa_slave_changeupper()
Date: Fri, 19 Aug 2022 20:52:13 +0300	[thread overview]
Message-ID: <20220819175153.d6p7atcmusuyzqvp@skbuf> (raw)
In-Reply-To: <CABikg9wx7vB5eRDAYtvAm7fprJ09Ta27a4ZazC=NX5K4wn6pWA@mail.gmail.com>

On Fri, Aug 19, 2022 at 06:11:46PM +0300, Sergei Antonov wrote:
> Hello!
> I am using the current netdev/net.git kernel. My DSA is mv88e6060
> (CONFIG_NET_DSA_MV88E6060).
> These two commands cause a crash:
> ~ # brctl addbr mybridge
> ~ # brctl addif mybridge lan2

Thanks for the report. Just to not leave this thread hanging, I've sent:
https://lore.kernel.org/netdev/20220819173925.3581871-1-vladimir.oltean@nxp.com/

FWIW, these days we use:
ip link add br0 type bridge
ip link set lan2 master br0

this is why normally it doesn't crash, extack is a netlink feature,
which brctl doesn't use. But we should keep ioctls working too, though.

      reply	other threads:[~2022-08-19 18:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19 15:11 mv88e6060: NULL dereference in dsa_slave_changeupper() Sergei Antonov
2022-08-19 17:52 ` Vladimir Oltean [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220819175153.d6p7atcmusuyzqvp@skbuf \
    --to=olteanv@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=saproj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox