From: Jakub Kicinski <kuba@kernel.org>
To: "huangguangbin (A)" <huangguangbin2@huawei.com>
Cc: <davem@davemloft.net>, <idosch@nvidia.com>,
<linux@rempel-privat.de>, <mkubecek@suse.cz>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lipeng321@huawei.com>, <shenjian15@huawei.com>
Subject: Re: [PATCH net-next 0/2] net: ethtool add VxLAN to the NFC API
Date: Mon, 22 Aug 2022 09:53:27 -0700 [thread overview]
Message-ID: <20220822095327.00b4ebd5@kernel.org> (raw)
In-Reply-To: <5062c7ae-3415-adf6-6488-f9a05177d2c2@huawei.com>
On Mon, 22 Aug 2022 22:46:14 +0800 huangguangbin (A) wrote:
> 1. I check the manual and implement of TC flower, it doesn't seems
> to support configuring flows steering to a specific queue.
We got an answer from Sridhar on that one (thanks!)
I know it was discussed so it's a SMOC.
> 2. Our hns3 driver has supported configuring some type of flows
> steering to a specific queue by ethtool -U command, many users
> have already use ethtool way.
> 3. In addition, if our driver supports TC flower to configure flows
> steering to a specific queue, can we allow user to simultaneously
> use TC flower and ethtool to configure flow rules? Could the rules
> configured by TC flower be queried by ethtool -u?
> If two ways can be existing, I think it is more complicated for
> driver to manage flow rules.
I understand your motivation and these are very valid points.
However, we have to draw the line somewhere. We have at least
three ways of configuring flow offloads (ethtool, nft, tc).
Supporting all of them is a lot of work for the drivers, leading
to a situation where there's no "standard Linux API" because each
vendor picks a slightly different approach :(
TC seems the most popular because of the OVS offload, so my preference
is to pick it over the other APIs.
next prev parent reply other threads:[~2022-08-22 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 14:35 [PATCH net-next 0/2] net: ethtool add VxLAN to the NFC API Guangbin Huang
2022-08-17 14:35 ` [PATCH net-next 1/2] net: ethtool: " Guangbin Huang
2022-08-17 14:35 ` [PATCH net-next 2/2] net: hns3: support set/get VxLAN rule of rx flow director by ethtool Guangbin Huang
2022-08-17 18:16 ` [PATCH net-next 0/2] net: ethtool add VxLAN to the NFC API Jakub Kicinski
2022-08-22 14:46 ` huangguangbin (A)
2022-08-22 15:48 ` Samudrala, Sridhar
2022-08-22 16:53 ` Jakub Kicinski [this message]
2022-08-23 8:20 ` huangguangbin (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822095327.00b4ebd5@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=huangguangbin2@huawei.com \
--cc=idosch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=lipeng321@huawei.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).