From: Jakub Kicinski <kuba@kernel.org>
To: Axel Rasmussen <axelrasmussen@google.com>
Cc: Andrei Vagin <avagin@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>, Jens Axboe <axboe@kernel.dk>,
Kees Cook <keescook@chromium.org>,
Paolo Abeni <pabeni@redhat.com>,
Pavel Begunkov <asml.silence@gmail.com>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linuxkselftest <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH] selftests: fix a couple missing .gitignore entries
Date: Mon, 22 Aug 2022 11:29:03 -0700 [thread overview]
Message-ID: <20220822112903.20ece35f@kernel.org> (raw)
In-Reply-To: <CAJHvVcgfdkrQSsoenyanjtuav9OK4w9YKVqinUiMrkvdgtB4sg@mail.gmail.com>
On Mon, 22 Aug 2022 09:17:57 -0700 Axel Rasmussen wrote:
> > Could you make the io_uring test the first in the file?
> > That'd gets us closest to the alphabetical ordering (I know the file is
> > not ordered now, but we should start moving that way).
>
> It isn't that it's mostly ordered with a few exceptions, to me it
> looks entirely random. I don't mind moving the one I'm adding but, I'm
> not sure it gives much value given that.
>
> Would folks object to just adding a second commit to this which sorts
> the file? Since this file isn't changed frequently, I would say the
> risk of annoying conflicts is pretty low.
It's a major source of conflicts for us, because everyone adds at
the end but patches may come in via multiple trees and pull requests.
I'm not opposed to the sort tho, maybe it's best to rip the band-aid
off once and for all.
prev parent reply other threads:[~2022-08-22 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 19:05 [PATCH] selftests: fix a couple missing .gitignore entries Axel Rasmussen
2022-08-19 19:07 ` Kees Cook
2022-08-19 23:07 ` Jakub Kicinski
2022-08-22 16:17 ` Axel Rasmussen
2022-08-22 18:29 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822112903.20ece35f@kernel.org \
--to=kuba@kernel.org \
--cc=asml.silence@gmail.com \
--cc=avagin@gmail.com \
--cc=axboe@kernel.dk \
--cc=axelrasmussen@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).