From: Florian Westphal <fw@strlen.de>
To: Gabriel Ryan <gabe@cs.columbia.edu>
Cc: Florian Westphal <fw@strlen.de>,
Abhishek Shah <abhishek.shah@columbia.edu>,
coreteam@netfilter.org, davem@davemloft.net, edumazet@google.com,
kadlec@netfilter.org, kuba@kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, pabeni@redhat.com,
pablo@netfilter.org, linux-kernel@vger.kernel.org
Subject: Re: data-race in nf_tables_newtable / nf_tables_newtable
Date: Mon, 22 Aug 2022 22:41:12 +0200 [thread overview]
Message-ID: <20220822204112.GA19050@breakpoint.cc> (raw)
In-Reply-To: <CALbthtdzW-_4TVngjt-VjCS6GqCEP967-UE7oEoDkBAVaRFOzw@mail.gmail.com>
Gabriel Ryan <gabe@cs.columbia.edu> wrote:
> Hi Florian,
>
> I just looked at the lock event trace from our report and it looks
> like two distinct commit mutexes were held when the race was
> triggered. I think the race is probably on the table_handle variable
> on net/netfilter/nf_tables_api.c:1221, and not the table->handle field
> being written to.
See
https://patchwork.ozlabs.org/project/netfilter-devel/patch/20220821085939.571378-1-pablo@netfilter.org/
which makes table_handle per netns.
next prev parent reply other threads:[~2022-08-22 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEHB2488dNqBKcgWLSeq500JLC1+q6RV=ENcUPm=rN9bWf0QkQ@mail.gmail.com>
2022-08-19 12:35 ` data-race in nf_tables_newtable / nf_tables_newtable Florian Westphal
2022-08-22 20:29 ` Gabriel Ryan
2022-08-22 20:41 ` Florian Westphal [this message]
2022-08-22 20:51 ` Gabriel Ryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822204112.GA19050@breakpoint.cc \
--to=fw@strlen.de \
--cc=abhishek.shah@columbia.edu \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gabe@cs.columbia.edu \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).