From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@nvidia.com,
pabeni@redhat.com, edumazet@google.com, saeedm@nvidia.com,
jacob.e.keller@intel.com, vikas.gupta@broadcom.com,
gospo@broadcom.com
Subject: Re: [patch net-next v2 4/4] net: devlink: expose the info about version representing a component
Date: Tue, 23 Aug 2022 12:31:21 -0700 [thread overview]
Message-ID: <20220823123121.0ae00393@kernel.org> (raw)
In-Reply-To: <YwR1URDk56l5VLDZ@nanopsycho>
On Tue, 23 Aug 2022 08:36:01 +0200 Jiri Pirko wrote:
> Tue, Aug 23, 2022 at 05:01:16AM CEST, kuba@kernel.org wrote:
> >I don't think we should add API without a clear use, let's drop this
> >as well.
>
> What do you mean? This just simply lists components that are possible to
> use with devlink dev flash. What is not clear? I don't follow.
Dumping random internal bits of the kernel is not how we create uAPIs.
Again, what is the scenario in which user space needs to know
the flashable component today ?
next prev parent reply other threads:[~2022-08-23 20:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 17:02 [patch net-next v2 0/4] net: devlink: sync flash and dev info commands Jiri Pirko
2022-08-22 17:02 ` [patch net-next v2 1/4] net: devlink: extend info_get() version put to indicate a flash component Jiri Pirko
2022-08-23 3:00 ` Jakub Kicinski
2022-08-23 6:35 ` Jiri Pirko
2022-08-23 19:32 ` Jakub Kicinski
2022-08-24 8:50 ` Jiri Pirko
2022-08-22 17:02 ` [patch net-next v2 2/4] netdevsim: add version fw.mgmt info info_get() and mark as a component Jiri Pirko
2022-08-22 17:02 ` [patch net-next v2 3/4] net: devlink: limit flash component name to match version returned by info_get() Jiri Pirko
2022-08-22 17:02 ` [patch net-next v2 4/4] net: devlink: expose the info about version representing a component Jiri Pirko
2022-08-23 3:01 ` Jakub Kicinski
2022-08-23 6:36 ` Jiri Pirko
2022-08-23 19:31 ` Jakub Kicinski [this message]
2022-08-24 8:49 ` Jiri Pirko
2022-08-24 17:31 ` Keller, Jacob E
2022-08-24 18:12 ` Jakub Kicinski
2022-08-24 18:46 ` Keller, Jacob E
2022-08-24 19:49 ` Andy Gospodarek
2022-08-22 19:23 ` [patch net-next v2 0/4] net: devlink: sync flash and dev info commands Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823123121.0ae00393@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=vikas.gupta@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).