From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org,
"Michael Chan" <michael.chan@broadcom.com>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Derek Chickles" <dchickles@marvell.com>,
"Satanand Burla" <sburla@marvell.com>,
"Felix Manlunas" <fmanlunas@marvell.com>,
"Raju Rangoju" <rajur@chelsio.com>,
"Dimitris Michailidis" <dmichail@fungible.com>,
"Yisen Zhuang" <yisen.zhuang@huawei.com>,
"Salil Mehta" <salil.mehta@huawei.com>,
"Jesse Brandeburg" <jesse.brandeburg@intel.com>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>,
"Sunil Goutham" <sgoutham@marvell.com>,
"Geetha sowjanya" <gakula@marvell.com>,
"Subbaraya Sundeep" <sbhatta@marvell.com>,
hariprasad <hkelam@marvell.com>,
"Taras Chornyi" <tchornyi@marvell.com>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Leon Romanovsky" <leon@kernel.org>,
"Simon Horman" <simon.horman@corigine.com>,
"Shannon Nelson" <snelson@pensando.io>,
"Ariel Elior" <aelior@marvell.com>,
"Manish Chopra" <manishc@marvell.com>,
"Edward Cree" <ecree.xilinx@gmail.com>,
"Martin Habets" <habetsm.xilinx@gmail.com>,
"Fei Qin" <fei.qin@corigine.com>,
"Louis Peens" <louis.peens@corigine.com>,
"Yu Xiao" <yu.xiao@corigine.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Yufeng Mo" <moyufeng@huawei.com>,
"Sixiang Chen" <sixiang.chen@corigine.com>,
"Yinjun Zhang" <yinjun.zhang@corigine.com>,
"Hao Chen" <chenhao288@hisilicon.com>,
"Guangbin Huang" <huangguangbin2@huawei.com>,
"Sean Anderson" <sean.anderson@seco.com>,
"Erik Ekman" <erik@kryo.se>, "Ido Schimmel" <idosch@nvidia.com>,
"Jie Wang" <wangjie125@huawei.com>,
"Moshe Tal" <moshet@nvidia.com>,
"Tonghao Zhang" <xiangxia.m.yue@gmail.com>,
"Marco Bonelli" <marco@mebeim.net>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: Re: [PATCH net-next 1/2] ethtool: pass netlink extended ACK to .set_fecparam
Date: Tue, 23 Aug 2022 15:13:54 -0700 [thread overview]
Message-ID: <20220823151354.4becbfe7@kernel.org> (raw)
In-Reply-To: <20220823150438.3613327-2-jacob.e.keller@intel.com>
On Tue, 23 Aug 2022 08:04:37 -0700 Jacob Keller wrote:
> Add the netlink extended ACK structure pointer to the interface for
> .set_fecparam. This allows reporting errors to the user appropriately when
> using the netlink ethtool interface.
Could you wrap it into a structure perhaps?
Would be good if we didn't have to modify the signature of the callback
next time we need to extend it (especially since struct ethtool_fecparam
is ioctl uABI so we can't really add fields there).
next prev parent reply other threads:[~2022-08-23 22:16 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 15:04 [PATCH net-next 0/2] ice: support FEC automatic disable Jacob Keller
2022-08-23 15:04 ` [PATCH net-next 1/2] ethtool: pass netlink extended ACK to .set_fecparam Jacob Keller
2022-08-23 15:06 ` Simon Horman
2022-08-23 22:13 ` Jakub Kicinski [this message]
2022-08-24 17:27 ` Keller, Jacob E
2022-08-23 15:04 ` [PATCH net-next 2/2] ice: add support for Auto FEC with FEC disabled via ETHTOOL_SFECPARAM Jacob Keller
2022-08-23 22:17 ` Jakub Kicinski
2022-08-24 17:29 ` Keller, Jacob E
2022-08-24 21:29 ` Keller, Jacob E
2022-08-24 22:47 ` Jakub Kicinski
2022-08-24 22:53 ` Keller, Jacob E
2022-08-24 23:02 ` Jakub Kicinski
2022-08-24 23:13 ` Keller, Jacob E
2022-08-24 23:32 ` Jakub Kicinski
2022-08-24 13:35 ` [PATCH net-next 0/2] ice: support FEC automatic disable Gal Pressman
2022-08-24 16:25 ` Jakub Kicinski
2022-08-25 7:08 ` Gal Pressman
2022-08-24 17:40 ` Keller, Jacob E
2022-08-25 7:08 ` Gal Pressman
2022-08-25 16:29 ` Jakub Kicinski
2022-08-25 16:57 ` Keller, Jacob E
2022-08-25 17:30 ` Jakub Kicinski
2022-08-25 17:51 ` Keller, Jacob E
2022-08-25 20:34 ` Jakub Kicinski
2022-08-25 21:04 ` Keller, Jacob E
2022-08-26 0:38 ` Jacob Keller
2022-08-26 1:01 ` Jakub Kicinski
2022-08-26 17:51 ` Jacob Keller
2022-08-26 23:57 ` Jakub Kicinski
2022-08-28 10:42 ` Gal Pressman
2022-08-29 7:11 ` Keller, Jacob E
2022-08-29 11:21 ` Gal Pressman
2022-08-29 18:10 ` Jacob Keller
2022-08-30 20:09 ` Jacob Keller
2022-08-30 21:44 ` Jakub Kicinski
2022-08-30 23:09 ` Keller, Jacob E
2022-08-31 11:01 ` Gal Pressman
2022-08-31 17:36 ` Jakub Kicinski
2022-09-01 11:52 ` Gal Pressman
2022-09-05 11:25 ` Gal Pressman
2022-08-31 20:15 ` Jacob Keller
2022-09-01 11:51 ` Gal Pressman
2022-09-01 17:59 ` Keller, Jacob E
2022-09-07 3:44 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823151354.4becbfe7@kernel.org \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=anthony.l.nguyen@intel.com \
--cc=chenhao288@hisilicon.com \
--cc=dchickles@marvell.com \
--cc=dmichail@fungible.com \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=erik@kryo.se \
--cc=fei.qin@corigine.com \
--cc=fmanlunas@marvell.com \
--cc=gakula@marvell.com \
--cc=gustavoars@kernel.org \
--cc=habetsm.xilinx@gmail.com \
--cc=hkelam@marvell.com \
--cc=huangguangbin2@huawei.com \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=leon@kernel.org \
--cc=louis.peens@corigine.com \
--cc=manishc@marvell.com \
--cc=marco@mebeim.net \
--cc=michael.chan@broadcom.com \
--cc=moshet@nvidia.com \
--cc=moyufeng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rajur@chelsio.com \
--cc=saeedm@nvidia.com \
--cc=salil.mehta@huawei.com \
--cc=sbhatta@marvell.com \
--cc=sburla@marvell.com \
--cc=sean.anderson@seco.com \
--cc=sgoutham@marvell.com \
--cc=simon.horman@corigine.com \
--cc=sixiang.chen@corigine.com \
--cc=snelson@pensando.io \
--cc=tchornyi@marvell.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wangjie125@huawei.com \
--cc=xiangxia.m.yue@gmail.com \
--cc=yinjun.zhang@corigine.com \
--cc=yisen.zhuang@huawei.com \
--cc=yu.xiao@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).