From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] ice: support FEC automatic disable
Date: Wed, 24 Aug 2022 09:25:21 -0700 [thread overview]
Message-ID: <20220824092521.1a02d280@kernel.org> (raw)
In-Reply-To: <e8251cef-585b-8992-f3b2-5d662071cab3@nvidia.com>
On Wed, 24 Aug 2022 16:35:41 +0300 Gal Pressman wrote:
> On 23/08/2022 18:04, Jacob Keller wrote:
> > 2) always treat ETHTOOL_FEC_AUTO as "automatic + allow disable"
> >
> > This could work, but it means that behavior will differ depending on the
> > firmware version. Users have no way to know that and might be surprised to
> > find the behavior differ across devices which have different firmware
> > which do or don't support this variation of automatic selection.
>
> Hi Jacob,
> This is exactly how it's already implemented in mlx5, and I don't really
> understand how firmware version is related? Is it specific to your
> device firmware?
> Maybe you can workaround that in the driver?
>
> I feel like we're going the wrong way here having different flags
> interpretations by different drivers.
Hm, according to my notes the drivers supporting a single bit and
multiple bits were evenly split when I wrote the docs. Either way
we're going to make someone unhappy?
While we're talking about mlx5 FEC, what does it report on get?
I wasn't sure if it reports the supported or configured mode.
next prev parent reply other threads:[~2022-08-24 16:25 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 15:04 [PATCH net-next 0/2] ice: support FEC automatic disable Jacob Keller
2022-08-23 15:04 ` [PATCH net-next 1/2] ethtool: pass netlink extended ACK to .set_fecparam Jacob Keller
2022-08-23 15:06 ` Simon Horman
2022-08-23 22:13 ` Jakub Kicinski
2022-08-24 17:27 ` Keller, Jacob E
2022-08-23 15:04 ` [PATCH net-next 2/2] ice: add support for Auto FEC with FEC disabled via ETHTOOL_SFECPARAM Jacob Keller
2022-08-23 22:17 ` Jakub Kicinski
2022-08-24 17:29 ` Keller, Jacob E
2022-08-24 21:29 ` Keller, Jacob E
2022-08-24 22:47 ` Jakub Kicinski
2022-08-24 22:53 ` Keller, Jacob E
2022-08-24 23:02 ` Jakub Kicinski
2022-08-24 23:13 ` Keller, Jacob E
2022-08-24 23:32 ` Jakub Kicinski
2022-08-24 13:35 ` [PATCH net-next 0/2] ice: support FEC automatic disable Gal Pressman
2022-08-24 16:25 ` Jakub Kicinski [this message]
2022-08-25 7:08 ` Gal Pressman
2022-08-24 17:40 ` Keller, Jacob E
2022-08-25 7:08 ` Gal Pressman
2022-08-25 16:29 ` Jakub Kicinski
2022-08-25 16:57 ` Keller, Jacob E
2022-08-25 17:30 ` Jakub Kicinski
2022-08-25 17:51 ` Keller, Jacob E
2022-08-25 20:34 ` Jakub Kicinski
2022-08-25 21:04 ` Keller, Jacob E
2022-08-26 0:38 ` Jacob Keller
2022-08-26 1:01 ` Jakub Kicinski
2022-08-26 17:51 ` Jacob Keller
2022-08-26 23:57 ` Jakub Kicinski
2022-08-28 10:42 ` Gal Pressman
2022-08-29 7:11 ` Keller, Jacob E
2022-08-29 11:21 ` Gal Pressman
2022-08-29 18:10 ` Jacob Keller
2022-08-30 20:09 ` Jacob Keller
2022-08-30 21:44 ` Jakub Kicinski
2022-08-30 23:09 ` Keller, Jacob E
2022-08-31 11:01 ` Gal Pressman
2022-08-31 17:36 ` Jakub Kicinski
2022-09-01 11:52 ` Gal Pressman
2022-09-05 11:25 ` Gal Pressman
2022-08-31 20:15 ` Jacob Keller
2022-09-01 11:51 ` Gal Pressman
2022-09-01 17:59 ` Keller, Jacob E
2022-09-07 3:44 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824092521.1a02d280@kernel.org \
--to=kuba@kernel.org \
--cc=gal@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).