From: Jakub Kicinski <kuba@kernel.org>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: Jiri Pirko <jiri@resnulli.us>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"idosch@nvidia.com" <idosch@nvidia.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"saeedm@nvidia.com" <saeedm@nvidia.com>,
"vikas.gupta@broadcom.com" <vikas.gupta@broadcom.com>,
"gospo@broadcom.com" <gospo@broadcom.com>
Subject: Re: [patch net-next v2 4/4] net: devlink: expose the info about version representing a component
Date: Wed, 24 Aug 2022 11:12:02 -0700 [thread overview]
Message-ID: <20220824111202.140ad1fb@kernel.org> (raw)
In-Reply-To: <CO1PR11MB508905A2019ED7C98C2CEB6FD6739@CO1PR11MB5089.namprd11.prod.outlook.com>
On Wed, 24 Aug 2022 17:31:46 +0000 Keller, Jacob E wrote:
> > Well, I thought it would be polite to let the user know what component
> > he can pass to the kernel. Now, it is try-fail/success game. But if you
> > think it is okay to let the user in the doubts, no problem. I will drop
> > the patch.
>
> I would prefer exposing this as well since it lets the user know which names are valid for flashing.
>
> I do have some patches for ice to support individual component update as well I can post soon.
Gentlemen, I had multiple false starts myself adding information
to device info, flashing and health reporters. Adding APIs which
will actually be _useful_ in production is not trivial. I have
the advantage of being able to talk to Meta's production team first
so none of my patches made it to the list.
To be clear I'm not saying (nor believe) that Meta's needs or processes
are in any way "the right way to go" or otherwise should dictate
the APIs. It's just an example I have direct access to.
I don't think I'm out of line asking you for a clear use case.
Just knowing something is flashable is not sufficient information,
the user needs to know what the component actually describes and
what binary to use to update it.
Since we have no use of component flashing now it's all cart
before the horse.
Coincidentally I doubt anyone is making serious use of the health
infrastructure.
next prev parent reply other threads:[~2022-08-24 18:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 17:02 [patch net-next v2 0/4] net: devlink: sync flash and dev info commands Jiri Pirko
2022-08-22 17:02 ` [patch net-next v2 1/4] net: devlink: extend info_get() version put to indicate a flash component Jiri Pirko
2022-08-23 3:00 ` Jakub Kicinski
2022-08-23 6:35 ` Jiri Pirko
2022-08-23 19:32 ` Jakub Kicinski
2022-08-24 8:50 ` Jiri Pirko
2022-08-22 17:02 ` [patch net-next v2 2/4] netdevsim: add version fw.mgmt info info_get() and mark as a component Jiri Pirko
2022-08-22 17:02 ` [patch net-next v2 3/4] net: devlink: limit flash component name to match version returned by info_get() Jiri Pirko
2022-08-22 17:02 ` [patch net-next v2 4/4] net: devlink: expose the info about version representing a component Jiri Pirko
2022-08-23 3:01 ` Jakub Kicinski
2022-08-23 6:36 ` Jiri Pirko
2022-08-23 19:31 ` Jakub Kicinski
2022-08-24 8:49 ` Jiri Pirko
2022-08-24 17:31 ` Keller, Jacob E
2022-08-24 18:12 ` Jakub Kicinski [this message]
2022-08-24 18:46 ` Keller, Jacob E
2022-08-24 19:49 ` Andy Gospodarek
2022-08-22 19:23 ` [patch net-next v2 0/4] net: devlink: sync flash and dev info commands Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824111202.140ad1fb@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=vikas.gupta@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).