From: Jakub Kicinski <kuba@kernel.org>
To: "Marek Behún" <kabel@kernel.org>
Cc: Marcus Carlberg <marcus.carlberg@axis.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, <kernel@axis.com>,
Pavana Sharma <pavana.sharma@digi.com>,
Ashkan Boldaji <ashkan.boldaji@digi.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] net: dsa: mv88e6xxx: support RGMII cmode
Date: Thu, 25 Aug 2022 15:51:40 -0700 [thread overview]
Message-ID: <20220825155140.038e4d12@kernel.org> (raw)
In-Reply-To: <20220826000605.5cff0db8@thinkpad>
On Fri, 26 Aug 2022 00:06:05 +0200 Marek Behún wrote:
> > On Mon, 22 Aug 2022 16:41:36 +0200 Marcus Carlberg wrote:
> > > Since the probe defaults all interfaces to the highest speed possible
> > > (10GBASE-X in mv88e6393x) before the phy mode configuration from the
> > > devicetree is considered it is currently impossible to use port 0 in
> > > RGMII mode.
> > >
> > > This change will allow RGMII modes to be configurable for port 0
> > > enabling port 0 to be configured as RGMII as well as serial depending
> > > on configuration.
> > >
> > > Fixes: de776d0d316f ("net: dsa: mv88e6xxx: add support for mv88e6393x family")
> > > Signed-off-by: Marcus Carlberg <marcus.carlberg@axis.com>
> >
> > Seems like a new configuration which was not previously supported
> > rather than a regression, right? If so I'll drop the Fixes tag
> > when applying.
>
> Please leave the fixes tag. This configuration should have been
> supported from the beginning.
Could you explain why? Is there an upstream-supported platform
already in Linus's tree which doesn't boot or something?
next prev parent reply other threads:[~2022-08-25 22:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 14:41 [PATCH v3] net: dsa: mv88e6xxx: support RGMII cmode Marcus Carlberg
2022-08-25 19:38 ` Jakub Kicinski
2022-08-25 22:06 ` Marek Behún
2022-08-25 22:51 ` Jakub Kicinski [this message]
2022-08-25 23:26 ` Marek Behún
2022-08-25 23:42 ` Jakub Kicinski
2022-08-26 0:05 ` Andrew Lunn
2022-08-27 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220825155140.038e4d12@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=ashkan.boldaji@digi.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kabel@kernel.org \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.carlberg@axis.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pavana.sharma@digi.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).