From: Mattias Forsblad <mattias.forsblad@gmail.com>
To: netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Mattias Forsblad <mattias.forsblad@gmail.com>
Subject: [PATCH net-next v2 3/3] rmon: Use RMU if available
Date: Fri, 26 Aug 2022 08:38:16 +0200 [thread overview]
Message-ID: <20220826063816.948397-4-mattias.forsblad@gmail.com> (raw)
In-Reply-To: <20220826063816.948397-1-mattias.forsblad@gmail.com>
If RMU is supported, use that interface to
collect rmon data.
Signed-off-by: Mattias Forsblad <mattias.forsblad@gmail.com>
---
drivers/net/dsa/mv88e6xxx/chip.c | 41 ++++++++++++++++++++++++++------
1 file changed, 34 insertions(+), 7 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 4c0510abd875..0d0241ace708 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -1226,16 +1226,30 @@ static int mv88e6xxx_stats_get_stats(struct mv88e6xxx_chip *chip, int port,
u16 bank1_select, u16 histogram)
{
struct mv88e6xxx_hw_stat *stat;
+ int offset = 0;
+ u64 high;
int i, j;
for (i = 0, j = 0; i < ARRAY_SIZE(mv88e6xxx_hw_stats); i++) {
stat = &mv88e6xxx_hw_stats[i];
if (stat->type & types) {
- mv88e6xxx_reg_lock(chip);
- data[j] = _mv88e6xxx_get_ethtool_stat(chip, stat, port,
- bank1_select,
- histogram);
- mv88e6xxx_reg_unlock(chip);
+ if (chip->rmu.ops && chip->rmu.ops->get_rmon &&
+ !(stat->type & STATS_TYPE_PORT)) {
+ if (stat->type & STATS_TYPE_BANK1)
+ offset = 32;
+
+ data[j] = chip->ports[port].rmu_raw_stats[stat->reg + offset];
+ if (stat->size == 8) {
+ high = chip->ports[port].rmu_raw_stats[stat->reg + offset
+ + 1];
+ data[j] += (high << 32);
+ }
+ } else {
+ mv88e6xxx_reg_lock(chip);
+ data[j] = _mv88e6xxx_get_ethtool_stat(chip, stat, port,
+ bank1_select, histogram);
+ mv88e6xxx_reg_unlock(chip);
+ }
j++;
}
@@ -1304,8 +1318,8 @@ static void mv88e6xxx_get_stats(struct mv88e6xxx_chip *chip, int port,
mv88e6xxx_reg_unlock(chip);
}
-static void mv88e6xxx_get_ethtool_stats(struct dsa_switch *ds, int port,
- uint64_t *data)
+static void mv88e6xxx_get_ethtool_stats_mdio(struct dsa_switch *ds, int port,
+ uint64_t *data)
{
struct mv88e6xxx_chip *chip = ds->priv;
int ret;
@@ -1319,7 +1333,20 @@ static void mv88e6xxx_get_ethtool_stats(struct dsa_switch *ds, int port,
return;
mv88e6xxx_get_stats(chip, port, data);
+}
+static void mv88e6xxx_get_ethtool_stats(struct dsa_switch *ds, int port,
+ uint64_t *data)
+{
+ struct mv88e6xxx_chip *chip = ds->priv;
+
+ /* If initialization of RMU isn't available
+ * fall back to MDIO access.
+ */
+ if (chip->rmu.ops && chip->rmu.ops->get_rmon)
+ chip->rmu.ops->get_rmon(chip, port, data);
+ else
+ mv88e6xxx_get_ethtool_stats_mdio(ds, port, data);
}
static int mv88e6xxx_get_regs_len(struct dsa_switch *ds, int port)
--
2.25.1
next prev parent reply other threads:[~2022-08-26 6:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 6:38 [PATCH net-next v2 0/3] net: dsa: mv88e6xxx: Add RMU support Mattias Forsblad
2022-08-26 6:38 ` [PATCH net-next v2 1/3] dsa: Implement RMU layer in DSA Mattias Forsblad
2022-08-26 19:27 ` Andrew Lunn
2022-08-29 6:10 ` Mattias Forsblad
2022-08-29 12:42 ` Andrew Lunn
2022-08-30 15:47 ` Vladimir Oltean
2022-08-31 5:55 ` Mattias Forsblad
2022-08-26 6:38 ` [PATCH net-next v2 2/3] dsa: mv88e6xxx: Add support for RMU in select switches Mattias Forsblad
2022-08-30 16:35 ` Vladimir Oltean
2022-08-30 16:42 ` Vladimir Oltean
2022-08-31 6:15 ` Mattias Forsblad
2022-09-01 9:05 ` Mattias Forsblad
2022-09-01 13:14 ` Vladimir Oltean
2022-08-31 6:12 ` Mattias Forsblad
2022-08-31 15:24 ` Vladimir Oltean
2022-08-26 6:38 ` Mattias Forsblad [this message]
2022-08-30 14:20 ` [PATCH net-next v2 3/3] rmon: Use RMU if available Vladimir Oltean
2022-08-31 5:51 ` Mattias Forsblad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826063816.948397-4-mattias.forsblad@gmail.com \
--to=mattias.forsblad@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).