From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B970EECAAD4 for ; Sat, 27 Aug 2022 01:37:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239126AbiH0BhQ (ORCPT ); Fri, 26 Aug 2022 21:37:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233267AbiH0BhP (ORCPT ); Fri, 26 Aug 2022 21:37:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD079DF0AF; Fri, 26 Aug 2022 18:37:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8B631B831BD; Sat, 27 Aug 2022 01:37:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA85DC433D6; Sat, 27 Aug 2022 01:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661564232; bh=gCe5krUjt94WhtRKYuI73X7CtqBoOaSa4DzCVLYy4Zw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=scS+oXKoPVI7/Fj6tkib3BKNPT+WmkmHIUQ54KyLmfgR3uZTZnojA/Ps//YoWJrJT MsWaN2mpo0SG58YVGaRTxprQ5dIHuS/UtSjMe+AEG+A3XiUxAY0VvPZl053N/iTiFv 7fU51+UuAsfptR3A7NYtonhfX4A3AwyazdxRwoPTof/7jPp8I18XS+62czefLJ79C2 +3bvldG3SZSh7z+dvuz9shcj8oEK1RbykDSs5pAlf1p8UnNiKASjT0z6wI8SMZqJtU zAuqsLCRqXrDod/AJcX2YRy7X9lphuMHRvT8GpfpNh8ODOkDit1gDowjc47+3E/8IB KiKxdpdOgJtFA== Date: Fri, 26 Aug 2022 18:37:11 -0700 From: Jakub Kicinski To: Andrew Lunn Cc: Horatiu Vultur , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, michael@walle.cc, UNGLinuxDriver@microchip.com, maxime.chevallier@bootlin.com Subject: Re: [PATCH net-next v2] net: phy: micrel: Make the GPIO to be non-exclusive Message-ID: <20220826183711.567bc7e8@kernel.org> In-Reply-To: References: <20220825201447.1444396-1-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 25 Aug 2022 22:16:31 +0200 Andrew Lunn wrote: > On Thu, Aug 25, 2022 at 10:14:47PM +0200, Horatiu Vultur wrote: > > The same GPIO line can be shared by multiple phys for the coma mode pin. > > If that is the case then, all the other phys that share the same line > > will failed to be probed because the access to the gpio line is not > > non-exclusive. > > Fix this by making access to the gpio line to be nonexclusive using flag > > GPIOD_FLAGS_BIT_NONEXCLUSIVE. This allows all the other PHYs to be > > probed. > > > > Fixes: 738871b09250ee ("net: phy: micrel: add coma mode GPIO") > > Signed-off-by: Horatiu Vultur > > Reviewed-by: Andrew Lunn The tree name switch in the subject compared to v1 is unintentional?