From: Jakub Kicinski <kuba@kernel.org>
To: David Thompson <davthompson@nvidia.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <cai.huoqing@linux.dev>,
<brgl@bgdev.pl>, <limings@nvidia.com>,
Asmaa Mnebhi <asmaa@nvidia.com>
Subject: Re: [PATCH net v1] mlxbf_gige: compute MDIO period based on i1clk
Date: Fri, 26 Aug 2022 18:49:22 -0700 [thread overview]
Message-ID: <20220826184922.030fccb3@kernel.org> (raw)
In-Reply-To: <20220826155916.12491-1-davthompson@nvidia.com>
On Fri, 26 Aug 2022 11:59:16 -0400 David Thompson wrote:
> This patch adds logic to compute the MDIO period based on
> the i1clk, and thereafter write the MDIO period into the YU
> MDIO config register. The i1clk resource from the ACPI table
> is used to provide addressing to YU bootrecord PLL registers.
> The values in these registers are used to compute MDIO period.
> If the i1clk resource is not present in the ACPI table, then
> the current default hardcorded value of 430Mhz is used.
> The i1clk clock value of 430MHz is only accurate for boards
> with BF2 mid bin and main bin SoCs. The BF2 high bin SoCs
> have i1clk = 500MHz, but can support a slower MDIO period.
>
> Fixes: f92e1869d74e ("Add Mellanox BlueField Gigabit Ethernet driver")
> Reviewed-by: Asmaa Mnebhi <asmaa@nvidia.com>
> Signed-off-by: David Thompson <davthompson@nvidia.com>
Hm, why did you repost this?
next prev parent reply other threads:[~2022-08-27 1:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 15:59 [PATCH net v1] mlxbf_gige: compute MDIO period based on i1clk David Thompson
2022-08-27 1:49 ` Jakub Kicinski [this message]
2022-09-01 15:32 ` David Thompson
2022-09-01 15:50 ` Jakub Kicinski
2022-08-31 19:20 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2022-08-24 22:32 David Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826184922.030fccb3@kernel.org \
--to=kuba@kernel.org \
--cc=asmaa@nvidia.com \
--cc=brgl@bgdev.pl \
--cc=cai.huoqing@linux.dev \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=limings@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).