From: Jakub Kicinski <kuba@kernel.org>
To: shaozhengchao <shaozhengchao@huawei.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<jhs@mojatatu.com>, <xiyou.wangcong@gmail.com>,
<jiri@resnulli.us>, <weiyongjun1@huawei.com>,
<yuehaibing@huawei.com>
Subject: Re: [PATCH net-next 0/3] net: sched: add other statistics when calling qdisc_drop()
Date: Mon, 29 Aug 2022 21:48:46 -0700 [thread overview]
Message-ID: <20220829214846.3fbb41b1@kernel.org> (raw)
In-Reply-To: <3bee0773-dc81-79b8-bddd-852141e3258c@huawei.com>
On Sat, 27 Aug 2022 11:16:53 +0800 shaozhengchao wrote:
> On 2022/8/27 10:40, Jakub Kicinski wrote:
> > On Thu, 25 Aug 2022 11:29:40 +0800 Zhengchao Shao wrote:
> >> According to the description, "other" should be added when calling
> >> qdisc_drop() to discard packets.
> >
> > The fact that an old copy & pasted comment says something is not
> > in itself a sufficient justification to make code changes.
> >
> > qdisc_drop() already counts drops, duplicating the same information
> > in another place seems like a waste of CPU cycles.
>
> Hi Jakub:
> Thank you for your reply. It seems more appropriate to delete the other
> variable, if it is unused?
Yes, removing it SGTM.
next prev parent reply other threads:[~2022-08-30 4:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 3:29 [PATCH net-next 0/3] net: sched: add other statistics when calling qdisc_drop() Zhengchao Shao
2022-08-25 3:29 ` [PATCH net-next 1/3] net: sched: sch_choke: add statistics when calling qdisc_drop() in sch_choke Zhengchao Shao
2022-08-25 3:29 ` [PATCH net-next 2/3] net: sched: sch_gred: add statistics when calling qdisc_drop() in sch_gred Zhengchao Shao
2022-08-25 3:29 ` [PATCH net-next 3/3] net: sched: sch_red: add statistics when calling qdisc_drop() in sch_red Zhengchao Shao
2022-08-27 2:40 ` [PATCH net-next 0/3] net: sched: add other statistics when calling qdisc_drop() Jakub Kicinski
2022-08-27 3:16 ` shaozhengchao
2022-08-30 4:48 ` Jakub Kicinski [this message]
2022-08-30 11:49 ` shaozhengchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829214846.3fbb41b1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).