From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Gal Pressman <gal@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Simon Horman <horms@verge.net.au>,
Andy Gospodarek <andy@greyhouse.net>
Subject: Re: [PATCH net-next 0/2] ice: support FEC automatic disable
Date: Tue, 30 Aug 2022 14:44:51 -0700 [thread overview]
Message-ID: <20220830144451.64fb8ea8@kernel.org> (raw)
In-Reply-To: <26384052-86fa-dc29-51d8-f154a0a71561@intel.com>
On Tue, 30 Aug 2022 13:09:20 -0700 Jacob Keller wrote:
> I'm trying to figure out what my next steps are here.
>
> Jakub, from earlier discussion it sounded like you are ok with accepting
> patch to include "No FEC" into our auto override behavior, with no uAPI
> changes. Is that still ok given the recent dicussion regarding going
> beyond the spec?
Yes, I reserve the right to change my mind :) but AFAIU it doesn't make
things worse, so fine by me.
> I'm also happy to rename the flag in ice so that its not misnamed and
> clearly indicates its behavior.
Which flag? A new ethtool priv flag?
> Gal seems against extending uAPI to indicate or support "ignore spec".
> To be properly correct that would mean changing ice to stop setting the
> AUTO_FEC flag. As explained above, I believe this will lead to breakage
> in situations where we used to link and function properly.
Stop setting the AUTO_FEC flag or start using a new standard compliant
AUTO flag?
Gal, within the spec do you iterate over modes or pick one mode somehow
(the spec gives a set, AFAICT)?
> I have no way to verify whether other vendors actually follow this or
> not, as it essentially requires checking with modules that wouldn't link
> otherwise and likely requires a lot of trial and error.
Getting some input from Broadcom or Netronome would be useful, yes :(
next prev parent reply other threads:[~2022-08-30 21:45 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 15:04 [PATCH net-next 0/2] ice: support FEC automatic disable Jacob Keller
2022-08-23 15:04 ` [PATCH net-next 1/2] ethtool: pass netlink extended ACK to .set_fecparam Jacob Keller
2022-08-23 15:06 ` Simon Horman
2022-08-23 22:13 ` Jakub Kicinski
2022-08-24 17:27 ` Keller, Jacob E
2022-08-23 15:04 ` [PATCH net-next 2/2] ice: add support for Auto FEC with FEC disabled via ETHTOOL_SFECPARAM Jacob Keller
2022-08-23 22:17 ` Jakub Kicinski
2022-08-24 17:29 ` Keller, Jacob E
2022-08-24 21:29 ` Keller, Jacob E
2022-08-24 22:47 ` Jakub Kicinski
2022-08-24 22:53 ` Keller, Jacob E
2022-08-24 23:02 ` Jakub Kicinski
2022-08-24 23:13 ` Keller, Jacob E
2022-08-24 23:32 ` Jakub Kicinski
2022-08-24 13:35 ` [PATCH net-next 0/2] ice: support FEC automatic disable Gal Pressman
2022-08-24 16:25 ` Jakub Kicinski
2022-08-25 7:08 ` Gal Pressman
2022-08-24 17:40 ` Keller, Jacob E
2022-08-25 7:08 ` Gal Pressman
2022-08-25 16:29 ` Jakub Kicinski
2022-08-25 16:57 ` Keller, Jacob E
2022-08-25 17:30 ` Jakub Kicinski
2022-08-25 17:51 ` Keller, Jacob E
2022-08-25 20:34 ` Jakub Kicinski
2022-08-25 21:04 ` Keller, Jacob E
2022-08-26 0:38 ` Jacob Keller
2022-08-26 1:01 ` Jakub Kicinski
2022-08-26 17:51 ` Jacob Keller
2022-08-26 23:57 ` Jakub Kicinski
2022-08-28 10:42 ` Gal Pressman
2022-08-29 7:11 ` Keller, Jacob E
2022-08-29 11:21 ` Gal Pressman
2022-08-29 18:10 ` Jacob Keller
2022-08-30 20:09 ` Jacob Keller
2022-08-30 21:44 ` Jakub Kicinski [this message]
2022-08-30 23:09 ` Keller, Jacob E
2022-08-31 11:01 ` Gal Pressman
2022-08-31 17:36 ` Jakub Kicinski
2022-09-01 11:52 ` Gal Pressman
2022-09-05 11:25 ` Gal Pressman
2022-08-31 20:15 ` Jacob Keller
2022-09-01 11:51 ` Gal Pressman
2022-09-01 17:59 ` Keller, Jacob E
2022-09-07 3:44 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220830144451.64fb8ea8@kernel.org \
--to=kuba@kernel.org \
--cc=andy@greyhouse.net \
--cc=gal@nvidia.com \
--cc=horms@verge.net.au \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).