From: Jakub Kicinski <kuba@kernel.org>
To: cgel.zte@gmail.com
Cc: idosch@nvidia.com, petrm@nvidia.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jinpeng Cui <cui.jinpeng2@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] mlxsw: remove redundant err variable
Date: Tue, 30 Aug 2022 23:05:19 -0700 [thread overview]
Message-ID: <20220830230519.4e92813a@kernel.org> (raw)
In-Reply-To: <20220829105454.266509-1-cui.jinpeng2@zte.com.cn>
On Mon, 29 Aug 2022 10:54:55 +0000 cgel.zte@gmail.com wrote:
> + return mlxsw_core_bus_device_register(mlxsw_core->bus_info,
> mlxsw_core->bus,
> mlxsw_core->bus_priv, true,
> devlink, extack);
Please realign continuation lines so that their starts match the
opening bracket. Please keep the review tags you received.
prev parent reply other threads:[~2022-08-31 6:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 10:54 [PATCH linux-next] mlxsw: remove redundant err variable cgel.zte
2022-08-29 11:11 ` Petr Machata
2022-08-29 12:14 ` Ammar Faizi
2022-08-31 6:05 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220830230519.4e92813a@kernel.org \
--to=kuba@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=cui.jinpeng2@zte.com.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).