* [PATCH linux-next] mlxsw: remove redundant err variable
@ 2022-08-29 10:54 cgel.zte
2022-08-29 11:11 ` Petr Machata
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: cgel.zte @ 2022-08-29 10:54 UTC (permalink / raw)
To: idosch
Cc: petrm, davem, edumazet, kuba, pabeni, netdev, linux-kernel,
Jinpeng Cui, Zeal Robot
From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Return value from mlxsw_core_bus_device_register() directly
instead of taking this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
---
drivers/net/ethernet/mellanox/mlxsw/core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
index afbe046b35a0..be9901ddf987 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
@@ -1496,15 +1496,14 @@ mlxsw_devlink_core_bus_device_reload_up(struct devlink *devlink, enum devlink_re
struct netlink_ext_ack *extack)
{
struct mlxsw_core *mlxsw_core = devlink_priv(devlink);
- int err;
*actions_performed = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT) |
BIT(DEVLINK_RELOAD_ACTION_FW_ACTIVATE);
- err = mlxsw_core_bus_device_register(mlxsw_core->bus_info,
+
+ return mlxsw_core_bus_device_register(mlxsw_core->bus_info,
mlxsw_core->bus,
mlxsw_core->bus_priv, true,
devlink, extack);
- return err;
}
static int mlxsw_devlink_flash_update(struct devlink *devlink,
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] mlxsw: remove redundant err variable
2022-08-29 10:54 [PATCH linux-next] mlxsw: remove redundant err variable cgel.zte
@ 2022-08-29 11:11 ` Petr Machata
2022-08-29 12:14 ` Ammar Faizi
2022-08-31 6:05 ` Jakub Kicinski
2 siblings, 0 replies; 4+ messages in thread
From: Petr Machata @ 2022-08-29 11:11 UTC (permalink / raw)
To: cgel.zte
Cc: idosch, petrm, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, Jinpeng Cui, Zeal Robot
cgel.zte@gmail.com writes:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
>
> Return value from mlxsw_core_bus_device_register() directly
> instead of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] mlxsw: remove redundant err variable
2022-08-29 10:54 [PATCH linux-next] mlxsw: remove redundant err variable cgel.zte
2022-08-29 11:11 ` Petr Machata
@ 2022-08-29 12:14 ` Ammar Faizi
2022-08-31 6:05 ` Jakub Kicinski
2 siblings, 0 replies; 4+ messages in thread
From: Ammar Faizi @ 2022-08-29 12:14 UTC (permalink / raw)
To: cgel.zte
Cc: idosch, petrm, David S. Miller, edumazet, Jakub Kicinski, pabeni,
netdev, Linux Kernel Mailing List, Jinpeng Cui, Zeal Robot
On Mon, Aug 29, 2022 at 5:56 PM wrote:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
>
> Return value from mlxsw_core_bus_device_register() directly
> instead of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Reviewed-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] mlxsw: remove redundant err variable
2022-08-29 10:54 [PATCH linux-next] mlxsw: remove redundant err variable cgel.zte
2022-08-29 11:11 ` Petr Machata
2022-08-29 12:14 ` Ammar Faizi
@ 2022-08-31 6:05 ` Jakub Kicinski
2 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-08-31 6:05 UTC (permalink / raw)
To: cgel.zte
Cc: idosch, petrm, davem, edumazet, pabeni, netdev, linux-kernel,
Jinpeng Cui, Zeal Robot
On Mon, 29 Aug 2022 10:54:55 +0000 cgel.zte@gmail.com wrote:
> + return mlxsw_core_bus_device_register(mlxsw_core->bus_info,
> mlxsw_core->bus,
> mlxsw_core->bus_priv, true,
> devlink, extack);
Please realign continuation lines so that their starts match the
opening bracket. Please keep the review tags you received.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-31 6:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-29 10:54 [PATCH linux-next] mlxsw: remove redundant err variable cgel.zte
2022-08-29 11:11 ` Petr Machata
2022-08-29 12:14 ` Ammar Faizi
2022-08-31 6:05 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).