From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A47D3ECAAD3 for ; Wed, 31 Aug 2022 17:36:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230332AbiHaRg3 (ORCPT ); Wed, 31 Aug 2022 13:36:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229866AbiHaRg2 (ORCPT ); Wed, 31 Aug 2022 13:36:28 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B9A9A7A8C for ; Wed, 31 Aug 2022 10:36:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D7875B82012 for ; Wed, 31 Aug 2022 17:36:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17D85C433C1; Wed, 31 Aug 2022 17:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661967385; bh=FrgFPh2mtHP6lk0aqaXsjmV+IL/Joe78oCvoyQHUv4s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u7vdni7RO/m6xJYU6HhD/SSOnptpW+qkGZ/JmnQBbxOmegUaez1YUjYHDPt2D4df+ lcmiqeZKytj5PXF3UcZw8pahV26yLfWxe9CzhrQevmwd9+bObbvUAhmfMWaC+PFVhg owIOXvKu8N6whlHHRr0kujYjrWiixez0g74x0Oftx9eCL++ucKXieQEQ8ihdnLSvAF LuAiNr0vVFBDQx02GI7n1vVUBk65+9s2arzO9WhWHpUI0Bz7PG09nPFQCuHNsCAqoP oCmwB50Lj0PHFYm332zf6bniKdn/9yawJAFm8ZFt3JVKH33gTmRnXARlw8bVc4n+Hs OizRyKoqmOV5A== Date: Wed, 31 Aug 2022 10:36:24 -0700 From: Jakub Kicinski To: Gal Pressman Cc: Jacob Keller , Saeed Mahameed , "netdev@vger.kernel.org" , Simon Horman , Andy Gospodarek Subject: Re: [PATCH net-next 0/2] ice: support FEC automatic disable Message-ID: <20220831103624.4ce0207b@kernel.org> In-Reply-To: <923e103e-b770-163b-f8b6-ff57305f8811@nvidia.com> References: <20220823150438.3613327-1-jacob.e.keller@intel.com> <5d9c6b31-cdf2-1285-6d4b-2368bae8b6f4@nvidia.com> <20220825092957.26171986@kernel.org> <20220825103027.53fed750@kernel.org> <20220825133425.7bfb34e9@kernel.org> <20220825180107.38915c09@kernel.org> <9d962e38-1aa9-d0ed-261e-eb77c82b186b@intel.com> <20220826165711.015e7827@kernel.org> <3f72e038-016d-8b1c-a215-243199bac033@intel.com> <26384052-86fa-dc29-51d8-f154a0a71561@intel.com> <20220830144451.64fb8ea8@kernel.org> <923e103e-b770-163b-f8b6-ff57305f8811@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 31 Aug 2022 14:01:10 +0300 Gal Pressman wrote: > When autoneg is disabled (and auto fec enabled), the firmware chooses > one of the supported modes according to the spec. Would you be able to provide the pointer in the spec / section which defines the behavior? It may be helpful to add that to the kdoc for ETHTOOL_FEC_AUTO_BIT.