From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Leon Romanovsky <leonro@nvidia.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
linux-wpan@vger.kernel.org,
Alexander Aring <alex.aring@gmail.com>
Subject: Re: [PATCH net-next] net: ieee802154: Fix compilation error when CONFIG_IEEE802154_NL802154_EXPERIMENTAL is disabled
Date: Wed, 31 Aug 2022 11:21:50 -0700 [thread overview]
Message-ID: <20220831112150.36e503bd@kernel.org> (raw)
In-Reply-To: <20220830233124.2770ffc2@kernel.org>
On Tue, 30 Aug 2022 23:31:24 -0700 Jakub Kicinski wrote:
> Hm, let me add 802154 folks.
>
> Either we should treat the commands as reserved in terms of uAPI
> even if they get removed the IDs won't be reused, or they are for
> testing purposes only.
>
> In the former case we should just remove the #ifdef around the values
> in the enum, it just leads to #ifdef proliferation while having no
> functional impact.
>
> In the latter case we should start error checking from the last
> non-experimental command, as we don't care about breaking the
> experimental ones.
I haven't gone thru all of my inbox yet, but I see no reply from Stefan
or Alexander. My vote is to un-hide the EXPERIMENTAL commands.
next prev parent reply other threads:[~2022-08-31 18:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 10:12 [PATCH net-next] net: ieee802154: Fix compilation error when CONFIG_IEEE802154_NL802154_EXPERIMENTAL is disabled Gal Pressman
2022-08-30 11:52 ` Sudip Mukherjee (Codethink)
2022-08-31 6:13 ` Jakub Kicinski
2022-08-31 6:20 ` Gal Pressman
2022-08-31 6:23 ` Leon Romanovsky
2022-08-31 6:31 ` Jakub Kicinski
2022-08-31 18:21 ` Jakub Kicinski [this message]
2022-08-31 19:21 ` Alexander Aring
2022-08-31 20:59 ` Stefan Schmidt
2022-08-31 21:09 ` Jakub Kicinski
2022-08-31 21:13 ` Stefan Schmidt
2022-09-01 6:38 ` Leon Romanovsky
2022-09-01 12:50 ` Alexander Aring
2022-09-01 13:05 ` Leon Romanovsky
2022-09-01 20:23 ` Jakub Kicinski
2022-09-02 2:48 ` Alexander Aring
2022-09-02 3:00 ` Jakub Kicinski
2022-09-02 10:35 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831112150.36e503bd@kernel.org \
--to=kuba@kernel.org \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=gal@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).