From: Jakub Kicinski <kuba@kernel.org>
To: Aleksander Jan Bajkowski <olek2@wp.pl>
Cc: hauke@hauke-m.de, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/1] net: lantiq_xrx200: use skb cache
Date: Wed, 31 Aug 2022 12:23:47 -0700 [thread overview]
Message-ID: <20220831122347.5c5dcb56@kernel.org> (raw)
In-Reply-To: <20220828191931.4923-2-olek2@wp.pl>
On Sun, 28 Aug 2022 21:19:31 +0200 Aleksander Jan Bajkowski wrote:
> @@ -239,7 +239,7 @@ static int xrx200_hw_receive(struct xrx200_chan *ch)
> return ret;
> }
>
> - skb = build_skb(buf, priv->rx_skb_size);
> + skb = napi_build_skb(buf, priv->rx_skb_size);
This gets called on MTU change, outside of softirq context, no?
prev parent reply other threads:[~2022-08-31 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-28 19:19 [PATCH net-next v2 0/1] net: lantiq_xrx200: use skb cache Aleksander Jan Bajkowski
2022-08-28 19:19 ` [PATCH net-next v2 1/1] " Aleksander Jan Bajkowski
2022-08-31 19:23 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831122347.5c5dcb56@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hauke@hauke-m.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).